Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756252AbcCaMCE (ORCPT ); Thu, 31 Mar 2016 08:02:04 -0400 Received: from mail.windriver.com ([147.11.1.11]:35201 "EHLO mail.windriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755938AbcCaMCC (ORCPT ); Thu, 31 Mar 2016 08:02:02 -0400 Subject: Re: [PATCH -repost] kgdb: depends on VT To: Jiri Slaby , References: <1459412955-4696-1-git-send-email-jslaby@suse.cz> CC: , , From: Jason Wessel Message-ID: <56FD11A9.1060305@windriver.com> Date: Thu, 31 Mar 2016 07:01:45 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <1459412955-4696-1-git-send-email-jslaby@suse.cz> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 646 Lines: 17 On 03/31/2016 03:29 AM, Jiri Slaby wrote: > With VT=n, the kernel build fails with: > drivers/built-in.o: In function `kgdboc_pre_exp_handler': > kgdboc.c:(.text+0x7b5aa): undefined reference to `fg_console' > kgdboc.c:(.text+0x7b5ce): undefined reference to `vc_cons' > kgdboc.c:(.text+0x7b5d5): undefined reference to `vc_cons' > > kgdboc.o is built when KGDB_SERIAL_CONSOLE is set. So make > KGDB_SERIAL_CONSOLE depend on HW_CONSOLE which includes those symbols. Acked-by: Jason Wessel I'll put this in the kgdb-next branch and submit it to the upstream, unless it gets merged in another queue. Thanks! Jason.