Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756461AbcCaMrj (ORCPT ); Thu, 31 Mar 2016 08:47:39 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:42722 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754567AbcCaMrh (ORCPT ); Thu, 31 Mar 2016 08:47:37 -0400 Date: Thu, 31 Mar 2016 14:47:31 +0200 From: Peter Zijlstra To: "Rafael J. Wysocki" Cc: Linux PM list , Juri Lelli , Steve Muckle , ACPI Devel Maling List , Linux Kernel Mailing List , Srinivas Pandruvada , Viresh Kumar , Vincent Guittot , Michael Turquette , Ingo Molnar Subject: Re: [PATCH v6 1/7][Resend] cpufreq: sched: Helpers to add and remove update_util hooks Message-ID: <20160331124731.GL3408@twins.programming.kicks-ass.net> References: <7262976.zPkLj56ATU@vostro.rjw.lan> <4984400.nsZvPb32HI@vostro.rjw.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4984400.nsZvPb32HI@vostro.rjw.lan> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1130 Lines: 27 On Tue, Mar 22, 2016 at 02:46:34AM +0100, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > Replace the single helper for adding and removing cpufreq utilization > update hooks, cpufreq_set_update_util_data(), with a pair of helpers, > cpufreq_add_update_util_hook() and cpufreq_remove_update_util_hook(), > and modify the users of cpufreq_set_update_util_data() accordingly. > > With the new helpers, the code using them doesn't need to worry > about the internals of struct update_util_data and in particular > it doesn't need to worry about populating the func field in it > properly upfront. > > Signed-off-by: Rafael J. Wysocki > --- > > No changes since v4 (this patch appeared then). > > --- > drivers/cpufreq/cpufreq_governor.c | 76 ++++++++++++++++++------------------- > drivers/cpufreq/intel_pstate.c | 8 +-- > include/linux/sched.h | 5 +- > kernel/sched/cpufreq.c | 48 ++++++++++++++++++----- > 4 files changed, 83 insertions(+), 54 deletions(-) > Acked-by: Peter Zijlstra (Intel)