Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756822AbcCaNBJ (ORCPT ); Thu, 31 Mar 2016 09:01:09 -0400 Received: from mail-oi0-f54.google.com ([209.85.218.54]:35602 "EHLO mail-oi0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753785AbcCaNBH (ORCPT ); Thu, 31 Mar 2016 09:01:07 -0400 MIME-Version: 1.0 In-Reply-To: <1459093489-18314-3-git-send-email-paul.gortmaker@windriver.com> References: <1459093489-18314-1-git-send-email-paul.gortmaker@windriver.com> <1459093489-18314-3-git-send-email-paul.gortmaker@windriver.com> Date: Thu, 31 Mar 2016 15:01:06 +0200 Message-ID: Subject: Re: [PATCH 2/9] drivers/gpio: make gpio-mb86s7x.c driver explicitly non-modular From: Linus Walleij To: Paul Gortmaker Cc: "linux-kernel@vger.kernel.org" , Alexandre Courbot , "linux-gpio@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 905 Lines: 27 On Sun, Mar 27, 2016 at 5:44 PM, Paul Gortmaker wrote: > The Kconfig for this driver is currently: > > config GPIO_MB86S7X > bool "GPIO support for Fujitsu MB86S7x Platforms" > > ...meaning that it currently is not being built as a module by anyone. > Lets remove the couple traces of modularity, so that when reading the > driver there is no doubt it is builtin-only. > > Since module_init translates to device_initcall in the non-modular > case, the init ordering remains unchanged with this commit. > > We also delete the MODULE_LICENSE tag etc. since all that information > is already contained at the top of the file in the comments. > > Cc: Linus Walleij > Cc: Alexandre Courbot > Cc: linux-gpio@vger.kernel.org > Signed-off-by: Paul Gortmaker Patch applied. Yours, Linus Walleij