Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756935AbcCaNCn (ORCPT ); Thu, 31 Mar 2016 09:02:43 -0400 Received: from mail-ob0-f171.google.com ([209.85.214.171]:34697 "EHLO mail-ob0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755980AbcCaNCl (ORCPT ); Thu, 31 Mar 2016 09:02:41 -0400 MIME-Version: 1.0 In-Reply-To: <1459093489-18314-4-git-send-email-paul.gortmaker@windriver.com> References: <1459093489-18314-1-git-send-email-paul.gortmaker@windriver.com> <1459093489-18314-4-git-send-email-paul.gortmaker@windriver.com> Date: Thu, 31 Mar 2016 15:02:40 +0200 Message-ID: Subject: Re: [PATCH 3/9] drivers/gpio: make gpio-mc9s08dz60.c explicitly non-modular From: Linus Walleij To: Paul Gortmaker Cc: "linux-kernel@vger.kernel.org" , Alexandre Courbot , Wu Guoxing , "linux-gpio@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1105 Lines: 32 On Sun, Mar 27, 2016 at 5:44 PM, Paul Gortmaker wrote: > The Kconfig currently controlling compilation of this code is: > > drivers/gpio/Kconfig:config GPIO_MC9S08DZ60 > drivers/gpio/Kconfig: bool "MX35 3DS BOARD MC9S08DZ60 GPIO functions" > > ...meaning that it currently is not being built as a module by anyone. > > Lets remove the modular code that is essentially orphaned, so that > when reading the driver there is no doubt it is builtin-only. > > Since module_i2c_driver() uses the same init level priority as > builtin_i2c_driver() the init ordering remains unchanged with > this commit. > > Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code. > > We also delete the MODULE_LICENSE tag etc. since all that information > is already contained at the top of the file in the comments. > > Cc: Linus Walleij > Cc: Alexandre Courbot > Cc: Wu Guoxing > Cc: linux-gpio@vger.kernel.org > Signed-off-by: Paul Gortmaker Patch applied. Yours, Linus Walleij