Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757154AbcCaNFU (ORCPT ); Thu, 31 Mar 2016 09:05:20 -0400 Received: from mail-ob0-f177.google.com ([209.85.214.177]:34844 "EHLO mail-ob0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756996AbcCaNFS (ORCPT ); Thu, 31 Mar 2016 09:05:18 -0400 MIME-Version: 1.0 In-Reply-To: <1459093489-18314-6-git-send-email-paul.gortmaker@windriver.com> References: <1459093489-18314-1-git-send-email-paul.gortmaker@windriver.com> <1459093489-18314-6-git-send-email-paul.gortmaker@windriver.com> Date: Thu, 31 Mar 2016 15:05:17 +0200 Message-ID: Subject: Re: [PATCH 5/9] drivers/gpio: make gpio-mvebu.c explicitly non-modular From: Linus Walleij To: Paul Gortmaker Cc: "linux-kernel@vger.kernel.org" , Alexandre Courbot , "linux-gpio@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 881 Lines: 28 On Sun, Mar 27, 2016 at 5:44 PM, Paul Gortmaker wrote: > The Kconfig currently controlling compilation of this code is: > > drivers/gpio/Kconfig:config GPIO_MVEBU > drivers/gpio/Kconfig: def_bool y > > ...meaning that it currently is not being built as a module by anyone. > > Lets remove the couple traces of modularity so that when reading the > driver there is no doubt it is builtin-only. > > Since module_platform_driver() uses the same init level priority as > builtin_platform_driver() the init ordering remains unchanged with > this commit. > > Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code. > > Cc: Linus Walleij > Cc: Alexandre Courbot > Cc: linux-gpio@vger.kernel.org > Signed-off-by: Paul Gortmaker Patch applied. Yours, Linus Walleij