Subject: Re: [PATCH 1/2] lightnvm: use rrpc->nr_luns to calculate the rrpc
 area size
To: Wenwei Tao <ww.tao0320@gmail.com>
References: <1459348115-6072-1-git-send-email-ww.tao0320@gmail.com>
 <CACygaLCJ9MCXRHh0D0RwQ4E61Q5X3Ymn0vE1O4Wx5mN5fy1_bQ@mail.gmail.com>
 <56FCE65D.8060901@lightnvm.io>
 <CACygaLBXO8ZF8GOWj1jMjYFd=2cq-noiO1tyAznbp+2pDU8wfw@mail.gmail.com>
 <56FCF6D0.7020009@lightnvm.io>
 <CACygaLDKuVvK0uH=iJ7d=JJGZtkzY10F=YQ-eJ64Xkk6M+EpyA@mail.gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-block@vger.kernel.org
From: =?UTF-8?Q?Matias_Bj=c3=b8rling?= <mb@lightnvm.io>
Message-ID: <56FD2548.1080607@lightnvm.io>
Date: Thu, 31 Mar 2016 15:25:28 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.4.0
MIME-Version: 1.0
In-Reply-To: <CACygaLDKuVvK0uH=iJ7d=JJGZtkzY10F=YQ-eJ64Xkk6M+EpyA@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 435
Lines: 9

On 03/31/2016 12:26 PM, Wenwei Tao wrote:
> This is okay with me.
> By the way, why don't you like  (sector_t)dev->sec_size *
> dev->sec_per_lun * rrpc->nr_luns, the change seems smaller?

Both works. I wanted to fix the underlying issue (which was rrpc values 
wasn't initialized enough to be used). Back when luns could be of 
different sizes, it made sense. Now that we can have the values up 
front, it makes sense to use them. :)