Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756961AbcCaN1A (ORCPT ); Thu, 31 Mar 2016 09:27:00 -0400 Received: from e06smtp08.uk.ibm.com ([195.75.94.104]:52693 "EHLO e06smtp08.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756498AbcCaN06 (ORCPT ); Thu, 31 Mar 2016 09:26:58 -0400 X-IBM-Helo: d06dlp03.portsmouth.uk.ibm.com X-IBM-MailFrom: schwidefsky@de.ibm.com X-IBM-RcptTo: linux-kernel@vger.kernel.org;linux-s390@vger.kernel.org Date: Thu, 31 Mar 2016 15:26:51 +0200 From: Martin Schwidefsky To: Linus Torvalds Cc: linux-kernel , linux-s390 , Heiko Carstens Subject: Re: [GIT PULL] s390 patches for 4.6-rc2 Message-ID: <20160331152651.650e334a@mschwide> In-Reply-To: References: <20160331145724.13258ddb@mschwide> X-Mailer: Claws Mail 3.9.3 (GTK+ 2.24.23; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16033113-0033-0000-0000-00000B1135F0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1487 Lines: 38 On Thu, 31 Mar 2016 07:59:56 -0500 Linus Torvalds wrote: > On Thu, Mar 31, 2016 at 7:57 AM, Martin Schwidefsky > wrote: > > > > to receive the following updates: > > > > * An interface for dasd driver to query if a volume is online to > > another operating system > > * A proper fix for the lcu locking issue in the dasd driver > > * Add the new preadv2 and pwritev2 system calls > > * Define the mark_rodata_ro function and set DEBUG_RODATA=y > > * A few more bug fixes. > > I'm not seeing that the dasd changes are bugfixes. > > Not pulled. You can try to explain more, but on the whole this looks > more like a new feature than anything else. The commit "s390/dasd: add query host access to volume support" introduces is an attribute 'host_access_count' to find out how many systems are using a particular device. This is indeed a new feature. The other large dasd patch "s390/dasd: reorder lcu and device lock" is a far better solution for the LCU locking that the git commit 9bfefde718c1352d "s390/dasd: fix incorrect locking order for LCU device add/remove" tries to solve. That commit has been added with the merge window patches for 4.6. I really would like to see the "s390/dasd: reorder lcu and device lock" go into 4.6 as the current solution is really ugly. But I'll remove the patch with the new attribute. Would that be acceptable? -- blue skies, Martin. "Reality continues to ruin my life." - Calvin.