Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756768AbcCaNgs (ORCPT ); Thu, 31 Mar 2016 09:36:48 -0400 Received: from mail.kernel.org ([198.145.29.136]:53308 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751607AbcCaNgq (ORCPT ); Thu, 31 Mar 2016 09:36:46 -0400 MIME-Version: 1.0 In-Reply-To: References: <1458838215-23314-1-git-send-email-narmstrong@baylibre.com> <1458838215-23314-13-git-send-email-narmstrong@baylibre.com> <20160325144834.GA27177@rob-hp-laptop> From: Rob Herring Date: Thu, 31 Mar 2016 08:36:23 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 12/18] dt-bindings: Add PLX Technology OXNAS pinctrl and gpio bindings To: Linus Walleij Cc: Neil Armstrong , "linux-kernel@vger.kernel.org" , Russell King - ARM Linux , "linux-arm-kernel@lists.infradead.org" , "linux-gpio@vger.kernel.org" , "devicetree@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1197 Lines: 30 On Thu, Mar 31, 2016 at 3:58 AM, Linus Walleij wrote: > On Fri, Mar 25, 2016 at 3:48 PM, Rob Herring wrote: >> On Thu, Mar 24, 2016 at 05:50:09PM +0100, Neil Armstrong wrote: >>> Add pinctrl and gpio DT bindings for PLX Technology OXNAS SoC Family. >>> This version supports the ARM926EJ-S based OX810SE SoC with 34 IO pins. >>> >>> Signed-off-by: Neil Armstrong > >>> + - plxtech,gpio-bank: Specifies which bank a controller owns. >> >> How is this used? > > That is used to give a unique ID number to the bank. > > Hardware often need this to cross-reference pin controllers > to GPIO banks. > > I should add it as "gpio-bank" to the generic bindings > instead, several platforms already use this and there is > no point in having a vendor prefix in front of it. Okay, now it is clearer. I don't want this documented as a common property because I don't want to encourage it's use. I only see 2 users currently: ST and PIC32. Looking at one example, it appears to be redundant already. nomadik-gpio-chips property already gives you the index. The index of the phandles is the bank numbering. PIC32 could do the same. Rob