Date: Thu, 31 Mar 2016 17:08:31 +0300
From: Antony Pavlov <antonynpavlov@gmail.com>
To: Ralf Baechle <ralf@linux-mips.org>
Cc: Sudip Mukherjee <sudipm.mukherjee@gmail.com>, linux-mips@linux-mips.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] MIPS: ath79: fix build failure
Message-Id: <20160331170831.d775fe49863273c06177a4be@gmail.com>
In-Reply-To: <20160330215618.GB5275@linux-mips.org>
References: <1459351789-24544-1-git-send-email-sudipm.mukherjee@gmail.com>
	<20160330221329.25ca0849d782e55c0564f139@gmail.com>
	<20160330215618.GB5275@linux-mips.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1171
Lines: 35

On Wed, 30 Mar 2016 23:56:18 +0200
Ralf Baechle <ralf@linux-mips.org> wrote:

> On Wed, Mar 30, 2016 at 10:13:29PM +0300, Antony Pavlov wrote:
> 
> > It is very strange because my original patch has this closing brace.
> > Please see my original patch
> > https://www.linux-mips.org/archives/linux-mips/2016-03/msg00267.html
> 
> The patch didn't apply cleanly and I botched resolving it, sorry.  I folded
> the fix into the patch.
> 
> > Also I suppose that we have no need in detect_memory_region() if we use devicetree,
> > e.g.
> > 
> >                 ath79_detect_sys_type();
> >                 ath79_ddr_ctrl_init();
> >  +              detect_memory_region(0, ATH79_MEM_SIZE_MIN, ATH79_MEM_SIZE_MAX);
> >  +      }
> >   
> >  -      detect_memory_region(0, ATH79_MEM_SIZE_MIN, ATH79_MEM_SIZE_MAX);
> 
> "suppose" is a bit weak..  Should I move the detect_memory_region call?

I have just examined lastest master from git://git.linux-mips.org/pub/scm/ralf/linux

The problem is a bit more complex. We have to move _machine_restart assignment too.

I'll send fixup in a few seconds.

Also please remove a dot from commit title.

--?
Best regards,
? Antony Pavlov