Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757028AbcCaOho (ORCPT ); Thu, 31 Mar 2016 10:37:44 -0400 Received: from smtp-outbound-2.vmware.com ([208.91.2.13]:39162 "EHLO smtp-outbound-2.vmware.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751609AbcCaOhm (ORCPT ); Thu, 31 Mar 2016 10:37:42 -0400 From: "Sinclair Yeh" Date: Thu, 31 Mar 2016 07:39:53 -0700 To: Greg KH Cc: x86@kernel.org, linux-kernel@vger.kernel.org, pv-drivers@vmware.com, Xavier Deguillard , virtualization@lists.linux-foundation.org Subject: Re: [PATCH 6/6] VMware balloon: Update vmw_balloon.c to use the VMW_PORT macro Message-ID: <20160331143953.GA23662@syeh-linux> References: <1449271183-1746-1-git-send-email-syeh@vmware.com> <1453239965-1466-1-git-send-email-syeh@vmware.com> <1453239965-1466-7-git-send-email-syeh@vmware.com> <20160208194157.GA10802@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160208194157.GA10802@kroah.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2151 Lines: 60 Hi, Does any one know when this series will be applied? Sinclair On Mon, Feb 08, 2016 at 11:41:57AM -0800, Greg KH wrote: > On Tue, Jan 19, 2016 at 01:46:05PM -0800, Sinclair Yeh wrote: > > Updated VMWARE_BALLOON_CMD to use the common VMW_PORT macro. > > Doing this rather than replacing all instances of VMWARE_BALLOON_CMD > > to minimize code change. > > > > Signed-off-by: Sinclair Yeh > > Reviewed-by: Thomas Hellstrom > > Reviewed-by: Alok N Kataria > > Acked-by: Xavier Deguillard > > Cc: pv-drivers@vmware.com > > Cc: Xavier Deguillard > > Cc: linux-kernel@vger.kernel.org > > Cc: virtualization@lists.linux-foundation.org > > Cc: Greg Kroah-Hartman > > > Acked-by: Greg Kroah-Hartman > > > -#define VMWARE_BALLOON_CMD(cmd, arg1, arg2, result) \ > > -({ \ > > - unsigned long __status, __dummy1, __dummy2, __dummy3; \ > > - __asm__ __volatile__ ("inl %%dx" : \ > > - "=a"(__status), \ > > - "=c"(__dummy1), \ > > - "=d"(__dummy2), \ > > - "=b"(result), \ > > - "=S" (__dummy3) : \ > > - "0"(VMW_BALLOON_HV_MAGIC), \ > > - "1"(VMW_BALLOON_CMD_##cmd), \ > > - "2"(VMW_BALLOON_HV_PORT), \ > > - "3"(arg1), \ > > - "4" (arg2) : \ > > - "memory"); \ > > - if (VMW_BALLOON_CMD_##cmd == VMW_BALLOON_CMD_START) \ > > - result = __dummy1; \ > > - result &= -1UL; \ > > - __status & -1UL; \ > > +#define VMWARE_BALLOON_CMD(cmd, arg1, arg2, result) \ > > +({ \ > > + unsigned long __status, __dummy1, __dummy2; \ > > + unsigned long __si, __di; \ > > + VMW_PORT(VMW_BALLOON_CMD_##cmd, arg1, arg2, 0, \ > > + VMW_BALLOON_HV_PORT, VMW_BALLOON_HV_MAGIC, \ > > + __status, result, __dummy1, __dummy2, __si, __di); \ > > + if (VMW_BALLOON_CMD_##cmd == VMW_BALLOON_CMD_START) \ > > + result = __dummy1; \ > > + result &= -1UL; \ > > + __status & -1UL; \ > > }) > > Honestly, it doesn't look anymore "readable" to me, but it's your code > to maintain, not mine... :) >