Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1757253AbcCaP5h (ORCPT <rfc822;w@1wt.eu>);
	Thu, 31 Mar 2016 11:57:37 -0400
Received: from mail-vk0-f48.google.com ([209.85.213.48]:34463 "EHLO
	mail-vk0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1756973AbcCaP5e (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 31 Mar 2016 11:57:34 -0400
MIME-Version: 1.0
In-Reply-To: <20160330203204.GA24156@roeck-us.net>
References: <1455534576-1486-1-git-send-email-ykk@rock-chips.com>
	<20160330203204.GA24156@roeck-us.net>
Date: Thu, 31 Mar 2016 08:57:31 -0700
X-Google-Sender-Auth: tpAJyItetlrneUBDt2eZRNgM50s
Message-ID: <CAD=FV=XkEb20_Ast80_7cVynifKxCWY18FFRN5mgD0Qq6FcXzw@mail.gmail.com>
Subject: Re: [v14, 01/17] drm: bridge: analogix/dp: split exynos dp driver to
 bridge directory
From: Doug Anderson <dianders@chromium.org>
To: Guenter Roeck <linux@roeck-us.net>, Yakir Yang <ykk@rock-chips.com>
Cc: Inki Dae <inki.dae@samsung.com>, Andrzej Hajda <a.hajda@samsung.com>,
        Joonyoung Shim <jy0922.shim@samsung.com>,
        Seung-Woo Kim <sw0312.kim@samsung.com>,
        Kyungmin Park <kyungmin.park@samsung.com>,
        Jingoo Han <jingoohan1@gmail.com>, Thierry Reding <treding@nvidia.com>,
        Krzysztof Kozlowski <k.kozlowski@samsung.com>,
        Rob Herring <robh+dt@kernel.org>, Heiko Stuebner <heiko@sntech.de>,
        Mark Yao <mark.yao@rock-chips.com>,
        Russell King <linux@arm.linux.org.uk>,
        Daniel Kurtz <djkurtz@chromium.org>, Sean Paul <seanpaul@chromium.org>,
        Kukjin Kim <kgene@kernel.org>, Kumar Gala <galak@codeaurora.org>,
        Emil Velikov <emil.l.velikov@gmail.com>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        Gustavo Padovan <gustavo.padovan@collabora.co.uk>,
        Kishon Vijay Abraham I <kishon@ti.com>,
        Pawel Moll <pawel.moll@arm.com>, Ajay kumar <ajaynumb@gmail.com>,
        Rob Herring <robherring2@gmail.com>,
        Javier Martinez Canillas <javier@osg.samsung.com>,
        Andy Yan <andy.yan@rock-chips.com>,
        "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        linux-samsung-soc <linux-samsung-soc@vger.kernel.org>,
        "open list:ARM/Rockchip SoC..." <linux-rockchip@lists.infradead.org>,
        "linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1203
Lines: 25

Hi,

On Wed, Mar 30, 2016 at 1:32 PM, Guenter Roeck <linux@roeck-us.net> wrote:
> This results in the following build errors if DRM_ANALOGIX_DP
> is configured as module.
>
> ERROR: "analogix_dp_start_video" [drivers/gpu/drm/bridge/analogix/analogix_dp_core.ko] undefined!
> ERROR: "analogix_dp_get_lane0_link_training" [drivers/gpu/drm/bridge/analogix/analogix_dp_core.ko] undefined!
> ERROR: "analogix_dp_get_lane1_link_training" [drivers/gpu/drm/bridge/analogix/analogix_dp_core.ko] undefined!
> ERROR: "analogix_dp_get_lane2_link_training" [drivers/gpu/drm/bridge/analogix/analogix_dp_core.ko] undefined!
> ERROR: "analogix_dp_get_lane3_link_training" [drivers/gpu/drm/bridge/analogix/analogix_dp_core.ko] undefined!
> ERROR: "analogix_dp_get_lane_count" [drivers/gpu/drm/bridge/analogix/analogix_dp_core.ko] undefined!
> ERROR: "analogix_dp_get_link_bandwidth" [drivers/gpu/drm/bridge/analogix/analogix_dp_core.ko] undefined!
>
> [ and so on ]
>
> It should probably be something like
>
> analogix_dp-objs := analogix_dp_core.o analogix_dp_reg.o
> obj-$(CONFIG_DRM_ANALOGIX_DP) += analogix_dp.o

Sounds like this is a major problem.  Presumably Yakir should fix and
send a new pull request?

-Doug