Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757915AbcCaRag (ORCPT ); Thu, 31 Mar 2016 13:30:36 -0400 Received: from mga01.intel.com ([192.55.52.88]:44575 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757644AbcCaRad (ORCPT ); Thu, 31 Mar 2016 13:30:33 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,423,1455004800"; d="scan'208";a="775592327" Message-ID: <1459445405.8191.32.camel@linux.intel.com> Subject: Re: [PATCH] kernfs: Move faulting copy_user operations outside of the mutex From: Joonas Lahtinen To: Tejun Heo , Chris Wilson , Daniel Vetter Cc: intel-gfx@lists.freedesktop.org, Ville =?ISO-8859-1?Q?Syrj=E4l=E4?= , Greg Kroah-Hartman , NeilBrown , linux-kernel@vger.kernel.org Date: Thu, 31 Mar 2016 20:30:05 +0300 In-Reply-To: <20160331164915.GC24661@htj.duckdns.org> References: <1459421106-17788-1-git-send-email-chris@chris-wilson.co.uk> <20160331164915.GC24661@htj.duckdns.org> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.18.5.2 (3.18.5.2-1.fc23) Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1138 Lines: 34 On to, 2016-03-31 at 12:49 -0400, Tejun Heo wrote: > On Thu, Mar 31, 2016 at 11:45:06AM +0100, Chris Wilson wrote: > > > > A fault in a user provided buffer may lead anywhere, and lockdep warns > > that we have a potential deadlock between the mm->mmap_sem and the > > kernfs file mutex: > ... > > > > Reported-by: Ville Syrjälä > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=94350 > > Signed-off-by: Chris Wilson > > Reviewed-by: Joonas Lahtinen > > Cc: Ville Syrjälä > > Cc: Joonas Lahtinen > > Cc: Tejun Heo > > Cc: Greg Kroah-Hartman > > Cc: NeilBrown > > Cc: linux-kernel@vger.kernel.org > Acked-by: Tejun Heo > Thanks. I have applied this locally to our repo to be included into our CI builds. We will drop the local patch once this waterfalls from upstream to our drm-intel-nightly repo. Regards, Joonas -- Joonas Lahtinen Open Source Technology Center Intel Corporation