Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756586AbcCaRoy (ORCPT ); Thu, 31 Mar 2016 13:44:54 -0400 Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:55691 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752654AbcCaRow (ORCPT ); Thu, 31 Mar 2016 13:44:52 -0400 Subject: Re: [PATCH 1/4] samples/bpf: Fix build breakage with map_perf_test_user.c To: "Naveen N. Rao" , , References: <922f95fb5d16686367a66d2d4bd176149a87e9ad.1459423412.git.naveen.n.rao@linux.vnet.ibm.com> CC: "David S . Miller" , Ananth N Mavinakayanahalli , Michael Ellerman , Daniel Borkmann , From: Alexei Starovoitov Message-ID: <56FD61B6.9000102@fb.com> Date: Thu, 31 Mar 2016 10:43:18 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:38.0) Gecko/20100101 Thunderbird/38.7.1 MIME-Version: 1.0 In-Reply-To: <922f95fb5d16686367a66d2d4bd176149a87e9ad.1459423412.git.naveen.n.rao@linux.vnet.ibm.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [192.168.52.123] X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-03-31_08:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1386 Lines: 39 On 3/31/16 4:25 AM, Naveen N. Rao wrote: > Building BPF samples is failing with the below error: > > samples/bpf/map_perf_test_user.c: In function ‘main’: > samples/bpf/map_perf_test_user.c:134:9: error: variable ‘r’ has > initializer but incomplete type > struct rlimit r = {RLIM_INFINITY, RLIM_INFINITY}; > ^ > Fix this by including the necessary header file. > > Cc: Alexei Starovoitov > Cc: David S. Miller > Cc: Ananth N Mavinakayanahalli > Cc: Michael Ellerman > Signed-off-by: Naveen N. Rao > --- > samples/bpf/map_perf_test_user.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/samples/bpf/map_perf_test_user.c b/samples/bpf/map_perf_test_user.c > index 95af56e..3147377 100644 > --- a/samples/bpf/map_perf_test_user.c > +++ b/samples/bpf/map_perf_test_user.c > @@ -17,6 +17,7 @@ > #include > #include > #include > +#include > #include "libbpf.h" > #include "bpf_load.h" It's failing this way on powerpc? Odd. Such hidden header dependency was always puzzling to me. Anyway: Acked-by: Alexei Starovoitov I'm assuming you want this set to go via 'net' tree, so please resubmit with [PATCH net 1/4] subjects and cc netdev. Reviewing your other patches...