Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756954AbcCaSPf (ORCPT ); Thu, 31 Mar 2016 14:15:35 -0400 Received: from mail-oi0-f51.google.com ([209.85.218.51]:35855 "EHLO mail-oi0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756551AbcCaSPd (ORCPT ); Thu, 31 Mar 2016 14:15:33 -0400 MIME-Version: 1.0 In-Reply-To: <20160331141308.GA9670@rob-hp-laptop> References: <1459277192-10942-1-git-send-email-simran.rai@broadcom.com> <1459277192-10942-2-git-send-email-simran.rai@broadcom.com> <20160331141308.GA9670@rob-hp-laptop> From: Simran Rai Date: Thu, 31 Mar 2016 11:14:53 -0700 Message-ID: Subject: Re: [PATCH resend v5 1/3] ASoC: cygnus: Add DT bindings for Broadcom Cygnus audio To: Rob Herring Cc: Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Ray Jui , Scott Branden , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Simran Rai , Lori Hikichi , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, bcm-kernel-feedback-list@broadcom.com, linux-kernel@vger.kernel.org, Arun Parameswaran , alsa-devel@alsa-project.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1313 Lines: 32 Hi Rob, On Thu, Mar 31, 2016 at 7:13 AM, Rob Herring wrote: > On Tue, Mar 29, 2016 at 11:46:30AM -0700, Simran Rai wrote: >> From: Simran Rai >> >> Add bindings for audio driver in Broadcom Cygnus. >> >> Signed-off-by: Lori Hikichi >> Signed-off-by: Simran Rai >> Reviewed-by: Ray Jui >> Reviewed-by: Scott Branden >> Signed-off-by: Simran Rai >> --- >> .../bindings/sound/brcm,cygnus-audio.txt | 67 ++++++++++++++++++++ >> 1 file changed, 67 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/sound/brcm,cygnus-audio.txt > > I acked v3 of this already. Did something change? If not, please add > acks when sending new versions. If things did change, explain that here. There was a change made in v4 that introduced assigned-clocks, assigned-clock-parents, and assigned-clock-rates, to allow initial configuration of default parent clock and its frequency. > > And this v5 is not a resend if you didn't already send out v5 before. I had sent out v5 on March 01 but looks like it did not make it to through. Yesterday I sent out another patch (v6) to address Mark's comments. Can you please ack PATCH v6. Thanks, Simran