Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757859AbcCaS2c (ORCPT ); Thu, 31 Mar 2016 14:28:32 -0400 Received: from mail-oi0-f41.google.com ([209.85.218.41]:33424 "EHLO mail-oi0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756307AbcCaS2a (ORCPT ); Thu, 31 Mar 2016 14:28:30 -0400 Date: Thu, 31 Mar 2016 13:28:21 -0500 From: Andy Gross To: Bjorn Andersson Cc: linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/5] soc: qcom: smem: Use write-combine remap for SMEM Message-ID: <20160331182821.GD8252@hector.attlocal.net> References: <1459226126-16725-1-git-send-email-bjorn.andersson@linaro.org> <1459226126-16725-2-git-send-email-bjorn.andersson@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1459226126-16725-2-git-send-email-bjorn.andersson@linaro.org> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 448 Lines: 11 On Mon, Mar 28, 2016 at 09:35:23PM -0700, Bjorn Andersson wrote: > Mapping the SMEM region as write combine makes the contiguous writes > in SMD perform better and also allows us to do unaligned read and writes > on ARM64. > > Signed-off-by: Bjorn Andersson Nice. This should make things work much better. The mappings should have been writecombine from the get go. Reviewed-by: Andy Gross