Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757337AbcCaTVM (ORCPT ); Thu, 31 Mar 2016 15:21:12 -0400 Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:46086 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752446AbcCaTVJ (ORCPT ); Thu, 31 Mar 2016 15:21:09 -0400 Subject: Re: [PATCH 3/4] samples/bpf: Simplify building BPF samples To: "Naveen N. Rao" References: <922f95fb5d16686367a66d2d4bd176149a87e9ad.1459423412.git.naveen.n.rao@linux.vnet.ibm.com> <0ce1c8bdff478db55490a90db6732c4db9de6f22.1459423412.git.naveen.n.rao@linux.vnet.ibm.com> <56FD632B.4040306@fb.com> <20160331185139.GD17907@naverao1-tp.ibm.com> CC: , , "David S . Miller" , Ananth N Mavinakayanahalli , Michael Ellerman , Daniel Borkmann , From: Alexei Starovoitov Message-ID: <56FD7888.9080902@fb.com> Date: Thu, 31 Mar 2016 12:20:40 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:38.0) Gecko/20100101 Thunderbird/38.7.1 MIME-Version: 1.0 In-Reply-To: <20160331185139.GD17907@naverao1-tp.ibm.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [192.168.52.123] X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-03-31_08:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1290 Lines: 34 On 3/31/16 11:51 AM, Naveen N. Rao wrote: > On 2016/03/31 10:49AM, Alexei Starovoitov wrote: >> On 3/31/16 4:25 AM, Naveen N. Rao wrote: >>> Make BPF samples build depend on CONFIG_SAMPLE_BPF. We still don't add a >>> Kconfig option since that will add a dependency on llvm for allyesconfig >>> builds which may not be desirable. >>> >>> Those who need to build the BPF samples can now just do: >>> >>> make CONFIG_SAMPLE_BPF=y >>> >>> or: >>> >>> export CONFIG_SAMPLE_BPF=y >>> make >> >> I don't like this 'simplification'. >> make samples/bpf/ >> is much easier to type than capital letters. > > This started out as a patch to have the BPF samples built with a Kconfig > option. As stated in the commit description, I realised that it won't > work for allyesconfig builds. However, the reason I retained this patch > is since it gets us one step closer to building the samples as part of > the kernel build. > > The 'simplification' is since I can now have the export in my .bashrc > and the kernel build will now build the BPF samples too without > requiring an additional 'make samples/bpf/' step. > > I agree this is subjective, so I am ok if this isn't taken in. If you can change it that 'make samples/bpf/' still works then it would be fine. As it is it breaks our testing setup.