Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757605AbcCaUJr (ORCPT ); Thu, 31 Mar 2016 16:09:47 -0400 Received: from mail-pf0-f175.google.com ([209.85.192.175]:34335 "EHLO mail-pf0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752826AbcCaUJo (ORCPT ); Thu, 31 Mar 2016 16:09:44 -0400 Date: Thu, 31 Mar 2016 13:09:39 -0700 From: Dmitry Torokhov To: Julien Chauveau Cc: Javier Martinez Canillas , Andreas =?iso-8859-1?Q?F=E4rber?= , linux-input@vger.kernel.org, Heiko Stuebner , "linux-arm-kernel@lists.infradead.org" , Linux Kernel , Geert Uytterhoeven , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" Subject: Re: [PATCH v2] Documentation: devicetree: Clean up gpio-keys example Message-ID: <20160331200939.GM39098@dtor-ws> References: <1458129209-15449-1-git-send-email-afaerber@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1064 Lines: 33 On Wed, Mar 16, 2016 at 10:55:53PM +0100, Julien Chauveau wrote: > > > Le 16 mars 2016 ? 15:47, Javier Martinez Canillas a ?crit : > > > > Hello Andreas, > > > > On Wed, Mar 16, 2016 at 8:53 AM, Andreas F?rber wrote: > >> Drop #address-cells and #size-cells, which are not required by the > >> gpio-keys binding documentation, as button sub-nodes are not devices. > >> > >> Rename sub-nodes to avoid new dtc unit address warnings when copied. > >> > >> While at it, adopt the dashes convention for the node name. > >> > >> Reported-by: Julien Chauveau > >> Cc: Julien Chauveau > >> Cc: Javier Martinez Canillas > >> Cc: Geert Uytterhoeven > >> Signed-off-by: Andreas F?rber > >> --- > > > > Patch looks good to me. > > > > Reviewed-by: Javier Martinez Canillas > > I agree. > > Reviewed-by: Julien Chauveau Applied, thank you. -- Dmitry