Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757581AbcCaUPW (ORCPT ); Thu, 31 Mar 2016 16:15:22 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:58604 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752578AbcCaUPV (ORCPT ); Thu, 31 Mar 2016 16:15:21 -0400 Date: Thu, 31 Mar 2016 13:15:20 -0700 From: Greg Kroah-Hartman To: Joonas Lahtinen Cc: Tejun Heo , Chris Wilson , Daniel Vetter , intel-gfx@lists.freedesktop.org, Ville =?iso-8859-1?Q?Syrj=E4l=E4?= , NeilBrown , linux-kernel@vger.kernel.org Subject: Re: [PATCH] kernfs: Move faulting copy_user operations outside of the mutex Message-ID: <20160331201520.GA22511@kroah.com> References: <1459421106-17788-1-git-send-email-chris@chris-wilson.co.uk> <20160331164915.GC24661@htj.duckdns.org> <1459445405.8191.32.camel@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1459445405.8191.32.camel@linux.intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1311 Lines: 36 On Thu, Mar 31, 2016 at 08:30:05PM +0300, Joonas Lahtinen wrote: > On to, 2016-03-31 at 12:49 -0400, Tejun Heo wrote: > > On Thu, Mar 31, 2016 at 11:45:06AM +0100, Chris Wilson wrote: > > > > > > A fault in a user provided buffer may lead anywhere, and lockdep warns > > > that we have a potential deadlock between the mm->mmap_sem and the > > > kernfs file mutex: > > ... > > > > > > Reported-by: Ville Syrj?l? > > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=94350 > > > Signed-off-by: Chris Wilson > > > Reviewed-by: Joonas Lahtinen > > > Cc: Ville Syrj?l? > > > Cc: Joonas Lahtinen > > > Cc: Tejun Heo > > > Cc: Greg Kroah-Hartman > > > Cc: NeilBrown > > > Cc: linux-kernel@vger.kernel.org > > Acked-by: Tejun Heo > > > > Thanks. > > I have applied this locally to our repo to be included into our CI > builds. > > We will drop the local patch once this waterfalls from upstream to our > drm-intel-nightly repo. So is this something that needs to get into 4.6-final because it resolves a reported issue? Or can it wait for 4.7-rc1? thanks, greg k-h