Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933524AbcCaUZw (ORCPT ); Thu, 31 Mar 2016 16:25:52 -0400 Received: from mail-lf0-f51.google.com ([209.85.215.51]:36782 "EHLO mail-lf0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933164AbcCaUZt (ORCPT ); Thu, 31 Mar 2016 16:25:49 -0400 Subject: Re: [PATCH v2 3/3] ARM: dts: apq8064: add ahci ports-implemented mask To: Srinivas Kandagatla , Tejun Heo , linux-ide@vger.kernel.org References: <1459445500-9071-1-git-send-email-srinivas.kandagatla@linaro.org> <1459445500-9071-4-git-send-email-srinivas.kandagatla@linaro.org> Cc: Rob Herring , Andy Gross , Hans de Goede , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, jmaggard10@gmail.com From: Sergei Shtylyov Organization: Cogent Embedded Message-ID: <56FD87C2.3020503@cogentembedded.com> Date: Thu, 31 Mar 2016 23:25:38 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <1459445500-9071-4-git-send-email-srinivas.kandagatla@linaro.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 887 Lines: 28 On 03/31/2016 08:31 PM, Srinivas Kandagatla wrote: > This patch adds new ports-implemented mask, which is required to get > achi working on the mainline. Without this patch value read from > PORTS_IMPL register which is zero would not enable any ports for > software to use. > > Signed-off-by: Srinivas Kandagatla > --- > arch/arm/boot/dts/qcom-apq8064.dtsi | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/qcom-apq8064.dtsi b/arch/arm/boot/dts/qcom-apq8064.dtsi > index 252b310..71d6fcb 100644 > --- a/arch/arm/boot/dts/qcom-apq8064.dtsi > +++ b/arch/arm/boot/dts/qcom-apq8064.dtsi > @@ -696,7 +696,7 @@ > }; > > sata0: sata@29000000 { > - compatible = "generic-ahci"; > + compatible = "generic-ahci", "qcom,apq8064-ahci"; The order of values should be reverse, no? [...] MBR, Sergei