From: Heiko Stuebner <heiko@sntech.de>
To: Andreas =?ISO-8859-1?Q?F=E4rber?= <afaerber@suse.de>
Cc: linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
        Pawel Moll <pawel.moll@arm.com>, Mark Rutland <mark.rutland@arm.com>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        Kumar Gala <galak@codeaurora.org>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Will Deacon <will.deacon@arm.com>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
	<devicetree@vger.kernel.org>
Subject: Re: [PATCH v4 1/8] arm64: dts: rockchip: Clean up /memory nodes
Date: Thu, 31 Mar 2016 22:45:52 +0200
Message-ID: <11405116.V0u286Y0bM@phil>
User-Agent: KMail/4.14.10 (Linux/4.3.0-1-amd64; KDE/4.14.14; x86_64; ; )
In-Reply-To: <1776429.KtRq374vTa@phil>
References: <1458136727-32075-1-git-send-email-afaerber@suse.de> <2027561.JLzKLXOoFO@phil> <1776429.KtRq374vTa@phil>
MIME-Version: 1.0
Content-Transfer-Encoding: 8BIT
Content-Type: text/plain; charset="iso-8859-1"
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1411
Lines: 32

Am Donnerstag, 31. M?rz 2016, 19:15:43 schrieb Heiko Stuebner:
> Am Samstag, 19. M?rz 2016, 09:04:08 schrieb Heiko Stuebner:
> > Am Mittwoch, 16. M?rz 2016, 14:58:39 schrieb Andreas F?rber:
> > > A dtc update results in warnings for nodes with reg property but
> > > without
> > > unit address in the node name, so rename /memory to /memory@0.
> > > 
> > > Signed-off-by: Andreas F?rber <afaerber@suse.de>
> > 
> > applied to a dts64-fixes branch for 4.6, after changing the commit
> > message to ----
> > A dtc update results in warnings for nodes with reg property but without
> > unit address in the node name, so rename /memory to /memory@startaddress
> > (memory starts at 0 in the case of the rk3368).
> > ----
> > 
> > To clarify that the @0 is not arbitary chosen.
> 
> This dtc update in question hasn't landed in v4.6-rc1 and from what I
> gathered will need some changes. The patch is obviously still correct, but
> I have now moved it from v4.6-fixes to the regular v4.7 64bit dts
> changes.

also it seems "memory" is special and memory without unitname will stay 
allowed [0], especially as uboot or other bootloaders may expect such a node 
to insert the actual amount of memory into it.

Looking at uboot, fdt_fixup_memory_banks seems to look explicitly for a 
"memory" node, so I'm actually not sure, if this is safe to keep at all.


[0] http://www.spinics.net/lists/arm-kernel/msg494038.html