Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758667AbcCaUrP (ORCPT ); Thu, 31 Mar 2016 16:47:15 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:59079 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758582AbcCaUrM (ORCPT ); Thu, 31 Mar 2016 16:47:12 -0400 Date: Thu, 31 Mar 2016 16:47:10 -0400 (EDT) Message-Id: <20160331.164710.1998871529914699937.davem@davemloft.net> To: thomas.petazzoni@free-electrons.com Cc: jszhang@marvell.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] net: mvneta: replace MVNETA_CPU_D_CACHE_LINE_SIZE with L1_CACHE_BYTES From: David Miller In-Reply-To: <20160331223735.32904e42@free-electrons.com> References: <1459338921-391-1-git-send-email-jszhang@marvell.com> <20160331.151547.1889188465826831929.davem@davemloft.net> <20160331223735.32904e42@free-electrons.com> X-Mailer: Mew version 6.6 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 31 Mar 2016 13:47:12 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 892 Lines: 30 From: Thomas Petazzoni Date: Thu, 31 Mar 2016 22:37:35 +0200 > Hello, > > On Thu, 31 Mar 2016 15:15:47 -0400 (EDT), David Miller wrote: >> From: Jisheng Zhang >> Date: Wed, 30 Mar 2016 19:55:21 +0800 >> >> > The mvneta is also used in some Marvell berlin family SoCs which may >> > have 64bytes cacheline size. Replace the MVNETA_CPU_D_CACHE_LINE_SIZE >> > usage with L1_CACHE_BYTES. >> > >> > And since dma_alloc_coherent() is always cacheline size aligned, so >> > remove the align checks. >> > >> > Signed-off-by: Jisheng Zhang >> >> Applied. > > A new version of the patch was sent, which more rightfully uses > cache_line_size(), see: > > "[PATCH v2] net: mvneta: replace MVNETA_CPU_D_CACHE_LINE_SIZE with cache_line_size" Sorry about that. Send me a realtive fixup patch if you like. Thanks.