Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758367AbcCaWAh (ORCPT ); Thu, 31 Mar 2016 18:00:37 -0400 Received: from mail-ig0-f194.google.com ([209.85.213.194]:35663 "EHLO mail-ig0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757597AbcCaWAZ (ORCPT ); Thu, 31 Mar 2016 18:00:25 -0400 MIME-Version: 1.0 In-Reply-To: <87wpoie6oj.fsf@x220.int.ebiederm.org> References: <1459281207-24377-1-git-send-email-sbauer@eng.utah.edu> <1459281207-24377-2-git-send-email-sbauer@eng.utah.edu> <87wpoie6oj.fsf@x220.int.ebiederm.org> Date: Thu, 31 Mar 2016 17:00:24 -0500 X-Google-Sender-Auth: hFX6w72g64OreAC72bEtro8oYoE Message-ID: Subject: Re: [PATCH v4 1/4] SROP Mitigation: Architecture independent code for signal cookies From: Linus Torvalds To: "Eric W. Biederman" Cc: Scott Bauer , Linux Kernel Mailing List , "kernel-hardening@lists.openwall.com" , "the arch/x86 maintainers" , Andi Kleen , Andy Lutomirski , Ingo Molnar , Thomas Gleixner , wmealing@redhat.com, Abhiram Balasubramanian , Scott Bauer Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 520 Lines: 16 On Thu, Mar 31, 2016 at 3:25 PM, Eric W. Biederman wrote: > > I suspect we want this to be a per-mm attribute rather than a per-thread > attribute. > > Otherwise you are breaking anything that uses a N-M threading model. > Which I suspect means that this implementation choice breaks all go > programs on linux. That sounds like a good point, but wouldn't it make more conceptual sense to make it part of "struct sighand_struct" instead? That is also shared for threads. Linus