Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758196AbcCaW2I (ORCPT ); Thu, 31 Mar 2016 18:28:08 -0400 Received: from out02.mta.xmission.com ([166.70.13.232]:35082 "EHLO out02.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755647AbcCaW2G (ORCPT ); Thu, 31 Mar 2016 18:28:06 -0400 From: ebiederm@xmission.com (Eric W. Biederman) To: Linus Torvalds Cc: Scott Bauer , Linux Kernel Mailing List , "kernel-hardening\@lists.openwall.com" , "the arch\/x86 maintainers" , Andi Kleen , Andy Lutomirski , Ingo Molnar , Thomas Gleixner , wmealing@redhat.com, Abhiram Balasubramanian , Scott Bauer References: <1459281207-24377-1-git-send-email-sbauer@eng.utah.edu> <1459281207-24377-2-git-send-email-sbauer@eng.utah.edu> <87wpoie6oj.fsf@x220.int.ebiederm.org> Date: Thu, 31 Mar 2016 17:17:53 -0500 In-Reply-To: (Linus Torvalds's message of "Thu, 31 Mar 2016 17:00:24 -0500") Message-ID: <87oa9ue1gu.fsf@x220.int.ebiederm.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-XM-AID: U2FsdGVkX1+XInnAhvcF1sMpP1zysPSQuaqeWSy/wEw= X-SA-Exim-Connect-IP: 67.3.249.252 X-SA-Exim-Mail-From: ebiederm@xmission.com X-Spam-Report: * -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP * 0.0 TVD_RCVD_IP Message was received from an IP address * 0.7 XMSubLong Long Subject * 0.0 T_TM2_M_HEADER_IN_MSG BODY: No description available. * -0.0 BAYES_40 BODY: Bayes spam probability is 20 to 40% * [score: 0.3275] * -0.0 DCC_CHECK_NEGATIVE Not listed in DCC * [sa06 1397; Body=1 Fuz1=1 Fuz2=1] X-Spam-DCC: XMission; sa06 1397; Body=1 Fuz1=1 Fuz2=1 X-Spam-Combo: ;Linus Torvalds X-Spam-Relay-Country: X-Spam-Timing: total 229 ms - load_scoreonly_sql: 0.04 (0.0%), signal_user_changed: 3.5 (1.5%), b_tie_ro: 2.4 (1.1%), parse: 0.68 (0.3%), extract_message_metadata: 15 (6.6%), get_uri_detail_list: 0.88 (0.4%), tests_pri_-1000: 8 (3.6%), tests_pri_-950: 1.34 (0.6%), tests_pri_-900: 1.08 (0.5%), tests_pri_-400: 19 (8.3%), check_bayes: 18 (7.8%), b_tokenize: 5 (2.2%), b_tok_get_all: 6 (2.5%), b_comp_prob: 1.82 (0.8%), b_tok_touch_all: 2.9 (1.3%), b_finish: 0.71 (0.3%), tests_pri_0: 152 (66.4%), check_dkim_signature: 0.51 (0.2%), check_dkim_adsp: 2.9 (1.3%), tests_pri_500: 25 (11.0%), poll_dns_idle: 18 (8.1%), rewrite_mail: 0.00 (0.0%) Subject: Re: [PATCH v4 1/4] SROP Mitigation: Architecture independent code for signal cookies X-Spam-Flag: No X-SA-Exim-Version: 4.2.1 (built Wed, 24 Sep 2014 11:00:52 -0600) X-SA-Exim-Scanned: Yes (on in01.mta.xmission.com) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 688 Lines: 21 Linus Torvalds writes: > On Thu, Mar 31, 2016 at 3:25 PM, Eric W. Biederman > wrote: >> >> I suspect we want this to be a per-mm attribute rather than a per-thread >> attribute. >> >> Otherwise you are breaking anything that uses a N-M threading model. >> Which I suspect means that this implementation choice breaks all go >> programs on linux. > > That sounds like a good point, but wouldn't it make more conceptual > sense to make it part of "struct sighand_struct" instead? > > That is also shared for threads. Good point. Given this is a signal handling feature struct sighand_struct is the natural place to put this. Eric