Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758221AbcDAAWB (ORCPT ); Thu, 31 Mar 2016 20:22:01 -0400 Received: from ozlabs.org ([103.22.144.67]:36745 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757962AbcDAAV5 (ORCPT ); Thu, 31 Mar 2016 20:21:57 -0400 From: Rusty Russell To: Jiri Kosina Cc: linux-kernel@vger.kernel.org, Andrew Morton Subject: Re: [PATCH v2] module: fix noreturn attribute for __module_put_and_exit() In-Reply-To: References: User-Agent: Notmuch/0.20.2 (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu) Date: Fri, 01 Apr 2016 10:24:55 +1030 Message-ID: <87k2ki8apc.fsf@rustcorp.com.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 772 Lines: 24 Jiri Kosina writes: > On Mon, 21 Mar 2016, Jiri Kosina wrote: > >> __module_put_and_exit() is makred noreturn in module.h declaration, but is >> lacking the attribute in the definition, which makes some tools (such as >> sparse) unhappy. Amend the definition with the attribute as well (and >> reformat the declaration so that it uses more common format). >> >> Signed-off-by: Jiri Kosina >> --- >> >> v1 -> v2: use __noreturn instead of __attribute__((noreturn)) as requested >> by Rusty > > Rusty, friendly ping on this one. > > Thanks! Oops, I applied it, and in testing noted that lguest had broken and ended up getting distracted by that. I've acked it now (it will probably wait until next merge window). Thanks, Rusty.