Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758113AbcDAAV7 (ORCPT ); Thu, 31 Mar 2016 20:21:59 -0400 Received: from ozlabs.org ([103.22.144.67]:34131 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757913AbcDAAV5 (ORCPT ); Thu, 31 Mar 2016 20:21:57 -0400 From: Rusty Russell To: Jiri Kosina Cc: linux-kernel@vger.kernel.org, Andrew Morton Subject: Re: [PATCH v2] module: fix noreturn attribute for __module_put_and_exit() In-Reply-To: References: User-Agent: Notmuch/0.20.2 (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu) Date: Fri, 01 Apr 2016 10:23:12 +1030 Message-ID: <87mvpe8as7.fsf@rustcorp.com.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 402 Lines: 12 Jiri Kosina writes: > __module_put_and_exit() is makred noreturn in module.h declaration, but is > lacking the attribute in the definition, which makes some tools (such as > sparse) unhappy. Amend the definition with the attribute as well (and > reformat the declaration so that it uses more common format). > > Signed-off-by: Jiri Kosina Applied. Thanks! Rusty.