Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1757324AbcDABTy (ORCPT <rfc822;w@1wt.eu>);
	Thu, 31 Mar 2016 21:19:54 -0400
Received: from imap.thunk.org ([74.207.234.97]:55444 "EHLO imap.thunk.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752160AbcDABTx (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Thu, 31 Mar 2016 21:19:53 -0400
Date: Thu, 31 Mar 2016 21:19:49 -0400
From: "Theodore Ts'o" <tytso@mit.edu>
To: Mike Marshall <hubcap@omnibond.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
        Martin Brandenburg <martin@omnibond.com>,
        Al Viro <viro@zeniv.linux.org.uk>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: [git pull] orangefs bugfixes for rc2
Message-ID: <20160401011949.GA29897@thunk.org>
Mail-Followup-To: Theodore Ts'o <tytso@mit.edu>,
	Mike Marshall <hubcap@omnibond.com>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Martin Brandenburg <martin@omnibond.com>,
	Al Viro <viro@zeniv.linux.org.uk>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>
References: <alpine.BSO.2.20.1603311208110.15868@server1.sysblue.org>
 <CA+55aFzRDqVaFw0mpHS5_VsyjP+b8KiLTP+a2opgDKOsLHCTLA@mail.gmail.com>
 <CAOg9mSTP0dnUQYpYcjwkqs+x0mC6o3zx7nq-OT5J=FeDJJ1Q-Q@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAOg9mSTP0dnUQYpYcjwkqs+x0mC6o3zx7nq-OT5J=FeDJJ1Q-Q@mail.gmail.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
X-SA-Exim-Connect-IP: <locally generated>
X-SA-Exim-Mail-From: tytso@thunk.org
X-SA-Exim-Scanned: No (on imap.thunk.org); SAEximRunCond expanded to false
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1665
Lines: 41

On Thu, Mar 31, 2016 at 05:01:47PM -0400, Mike Marshall wrote:
> 
> but from our kernel.org tree... pull requests for reviewed code
> from kernel.org doesn't need signed tags...

Signed tags are considered best practice, even if your git tree is
hosted on git.kernel.org.  One of the reasons for this is because even
after Linus merges your changes, someone can independently verify that
the changes came from you; they don't have to trust Linus or whatever
git server they happened to pull the tree from.  For example, try
running the command:

  git show --show-signature faeb20ecfa398b043c3224607f512c009c51653d

You'll see something like this:

commit faeb20ecfa398b043c3224607f512c009c51653d
merged tag 'ext4_for_linus'
gpg: Signature made Wed 16 Mar 2016 05:25:58 PM EDT
gpg:                using RSA key 0xF2F95956950D81A3
gpg: Good signature from "Theodore Ts'o <tytso@mit.edu>" [ultimate]
gpg:                 aka "Theodore Ts'o <tytso@debian.org>" [ultimate]
gpg:                 aka "Theodore Ts'o <tytso@google.com>" [ultimate]
Primary key fingerprint: 3AB0 57B7 E78D 945C 8C55  91FB D36F 769B C118 04F0
     Subkey fingerprint: 2B69 B954 DBFE 0879 2881  37C9 F2F9 5956 950D 81A3
Merge: 364e8dd 0304688
Author: Linus Torvalds <torvalds@linux-foundation.org>
Date:   Thu Mar 17 16:31:18 2016 -0700

    Merge tag 'ext4_for_linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4
    
    Pull ext4 updates from Ted Ts'o:
     "Performance improvements in SEEK_DATA and xattr scalability
      improvements, plus a lot of clean ups and bug fixes"

So while a signed tag might not be _required_, it's definitely
preferred.

Cheers,

						- Ted