Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758479AbcDACsz (ORCPT ); Thu, 31 Mar 2016 22:48:55 -0400 Received: from mail-wm0-f42.google.com ([74.125.82.42]:34923 "EHLO mail-wm0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753707AbcDACsx (ORCPT ); Thu, 31 Mar 2016 22:48:53 -0400 Message-ID: <1459478930.6099.249.camel@nexus-software.ie> Subject: Re: [PATCH 4/4] efi: A misc char interface to update EFI firmware From: deckard To: Matt Fleming , linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org Cc: joeyli , "Kweh, Hock Leong" , Ard Biesheuvel , Borislav Petkov , Andy Lutomirski , Sam Protsenko , Peter Jones , Greg Kroah-Hartman Date: Fri, 01 Apr 2016 03:48:50 +0100 In-Reply-To: <1458219431-24741-5-git-send-email-matt@codeblueprint.co.uk> References: <1458219431-24741-1-git-send-email-matt@codeblueprint.co.uk> <1458219431-24741-5-git-send-email-matt@codeblueprint.co.uk> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.5-1ubuntu3.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 786 Lines: 20 On Thu, 2016-03-17 at 12:57 +0000, Matt Fleming wrote: > Tested with Intel Quark Galileo GEN1 platform. + * If the capsule is successfully submitted to the firmware, any + * subsequent calls to efi_capsule_pending() will return true. @pages + * must not be released or modified if this function returns + * successfully. The only minor nit here is that you can't actually test this on a Galileo GEN1 since there's a non-standard header required to update the firmware on that platform ! So I suggest dropping that particular comment in the git log, since you can't actually *do* that on a Galileo without doing something about the required CSH (Clanton Secure Header) prefixed to the standard Capsule header. Otherwise. Reviewed-by: Bryan O'Donoghue