Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758320AbcDADeE (ORCPT ); Thu, 31 Mar 2016 23:34:04 -0400 Received: from mx0b-00082601.pphosted.com ([67.231.153.30]:29319 "EHLO mx0b-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753477AbcDADeB (ORCPT ); Thu, 31 Mar 2016 23:34:01 -0400 Subject: Re: [PATCHSET v3][RFC] Make background writeback not suck To: Dave Chinner References: <1459350477-16404-1-git-send-email-axboe@fb.com> <20160331082433.GO11812@dastard> <56FD344F.70908@fb.com> <56FD4E70.3090203@fb.com> <20160401005608.GU11812@dastard> <56FDEB1A.2030404@fb.com> CC: , , From: Jens Axboe Message-ID: <56FDEC23.8000009@fb.com> Date: Thu, 31 Mar 2016 21:33:55 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <56FDEB1A.2030404@fb.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [192.168.54.13] X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-04-01_01:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 725 Lines: 18 On 03/31/2016 09:29 PM, Jens Axboe wrote: >> I'm not changing the host kernels - it's a production machine and so >> it runs long uptime testing of stable kernels. (e.g. catch slow >> memory leaks, etc). So if you've disabled throttling in the guest, I >> can't test the throttling changes. > > Right, that'd definitely hide the problem for you. I'll see if I can get > it in a reproducible state and take it from there. Though on the guest, if you could try with just this one applied: http://git.kernel.dk/cgit/linux-block/commit/?h=wb-buf-throttle&id=f21fb0e42c7347bd639a17341dcd3f72c1a30d29 I'd appreciate it. It won't disable the throttling in the guest, just treat META and PRIO a bit differently. -- Jens Axboe