Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932437AbcCHIBU (ORCPT ); Tue, 8 Mar 2016 03:01:20 -0500 Received: from tama50.ecl.ntt.co.jp ([129.60.39.147]:39173 "EHLO tama50.ecl.ntt.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932359AbcCHIBE (ORCPT ); Tue, 8 Mar 2016 03:01:04 -0500 Subject: Re: [PATCH v2 0/9] cleanup around kvm_sync_page, and a few micro-optimizations References: <1457360155-9610-1-git-send-email-pbonzini@redhat.com> <1457360155-9610-2-git-send-email-pbonzini@redhat.com> From: Takuya Yoshikawa Message-ID: <56DE869B.9030908@lab.ntt.co.jp> Date: Tue, 8 Mar 2016 17:00:27 +0900 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <1457360155-9610-2-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset=iso-2022-jp Content-Transfer-Encoding: 7bit To: Paolo Bonzini , linux-kernel@vger.kernel.org, kvm@vger.kernel.org Cc: Xiao Guangrong X-TM-AS-MML: disable Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 919 Lines: 27 On 2016/03/07 23:15, Paolo Bonzini wrote: > Having committed the ubsan fixes, this are the cleanups that are left. > > Compared to v1, I have fixed the patch to coalesce page zapping after > mmu_sync_children (as requested by Takuya and Guangrong), and I have > rewritten is_last_gpte again in an even simpler way. > > Paolo > > Paolo Bonzini (9): > KVM: MMU: introduce kvm_mmu_flush_or_zap > KVM: MMU: move TLB flush out of __kvm_sync_page > KVM: MMU: use kvm_sync_page in kvm_sync_pages > KVM: MMU: cleanup __kvm_sync_page and its callers > KVM: MMU: invert return value of mmu.sync_page and *kvm_sync_page* > KVM: MMU: move zap/flush to kvm_mmu_get_page > KVM: MMU: coalesce more page zapping in mmu_sync_children 1-7 look good to me. > KVM: MMU: simplify is_last_gpte > KVM: MMU: micro-optimize gpte_access 8 and 9 look reasonable to me, though I read them only briefly. Takuya