Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754088AbcCHIa5 (ORCPT ); Tue, 8 Mar 2016 03:30:57 -0500 Received: from mail-wm0-f67.google.com ([74.125.82.67]:35905 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753677AbcCHIat (ORCPT ); Tue, 8 Mar 2016 03:30:49 -0500 Subject: Re: [PATCH v2 0/9] cleanup around kvm_sync_page, and a few micro-optimizations To: Takuya Yoshikawa , linux-kernel@vger.kernel.org, kvm@vger.kernel.org References: <1457360155-9610-1-git-send-email-pbonzini@redhat.com> <1457360155-9610-2-git-send-email-pbonzini@redhat.com> <56DE869B.9030908@lab.ntt.co.jp> Cc: Xiao Guangrong From: Paolo Bonzini Message-ID: <56DE8DB5.5090700@redhat.com> Date: Tue, 8 Mar 2016 09:30:45 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <56DE869B.9030908@lab.ntt.co.jp> Content-Type: text/plain; charset=iso-2022-jp Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 576 Lines: 16 On 08/03/2016 09:00, Takuya Yoshikawa wrote: > > KVM: MMU: introduce kvm_mmu_flush_or_zap > > KVM: MMU: move TLB flush out of __kvm_sync_page > > KVM: MMU: use kvm_sync_page in kvm_sync_pages > > KVM: MMU: cleanup __kvm_sync_page and its callers > > KVM: MMU: invert return value of mmu.sync_page and *kvm_sync_page* > > KVM: MMU: move zap/flush to kvm_mmu_get_page > > KVM: MMU: coalesce more page zapping in mmu_sync_children > > 1-7 look good to me. Great, these are the ones where I wanted more review. Can I add your Reviewed-by for these? Paolo