Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932331AbcCHIeY (ORCPT ); Tue, 8 Mar 2016 03:34:24 -0500 Received: from tama500.ecl.ntt.co.jp ([129.60.39.148]:50781 "EHLO tama500.ecl.ntt.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753545AbcCHIeQ (ORCPT ); Tue, 8 Mar 2016 03:34:16 -0500 Subject: Re: [PATCH v2 0/9] cleanup around kvm_sync_page, and a few micro-optimizations References: <1457360155-9610-1-git-send-email-pbonzini@redhat.com> <1457360155-9610-2-git-send-email-pbonzini@redhat.com> <56DE869B.9030908@lab.ntt.co.jp> <56DE8DB5.5090700@redhat.com> From: Takuya Yoshikawa Message-ID: <56DE8E73.80604@lab.ntt.co.jp> Date: Tue, 8 Mar 2016 17:33:55 +0900 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <56DE8DB5.5090700@redhat.com> Content-Type: text/plain; charset=iso-2022-jp Content-Transfer-Encoding: 7bit To: Paolo Bonzini , linux-kernel@vger.kernel.org, kvm@vger.kernel.org Cc: Xiao Guangrong X-TM-AS-MML: disable Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 722 Lines: 23 On 2016/03/08 17:30, Paolo Bonzini wrote: > On 08/03/2016 09:00, Takuya Yoshikawa wrote: >>> KVM: MMU: introduce kvm_mmu_flush_or_zap >>> KVM: MMU: move TLB flush out of __kvm_sync_page >>> KVM: MMU: use kvm_sync_page in kvm_sync_pages >>> KVM: MMU: cleanup __kvm_sync_page and its callers >>> KVM: MMU: invert return value of mmu.sync_page and *kvm_sync_page* >>> KVM: MMU: move zap/flush to kvm_mmu_get_page >>> KVM: MMU: coalesce more page zapping in mmu_sync_children >> >> 1-7 look good to me. > > Great, these are the ones where I wanted more review. > > Can I add your Reviewed-by for these? Yes, please. Reviewed-by: Takuya Yoshikawa Takuya