Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755414AbcCUMfP (ORCPT ); Mon, 21 Mar 2016 08:35:15 -0400 Received: from mprc.pku.edu.cn ([162.105.203.9]:60165 "EHLO mprc.pku.edu.cn" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755299AbcCUMfO (ORCPT ); Mon, 21 Mar 2016 08:35:14 -0400 X-Greylist: delayed 2664 seconds by postgrey-1.27 at vger.kernel.org; Mon, 21 Mar 2016 08:35:13 EDT Message-ID: <63436.117.114.135.40.1458560849.squirrel@mprc.pku.edu.cn> In-Reply-To: <1458559253-422-1-git-send-email-linux@roeck-us.net> References: <1458559253-422-1-git-send-email-linux@roeck-us.net> Date: Mon, 21 Mar 2016 19:47:29 +0800 (CST) Subject: Re: [PATCH] unicore32: mm: Add missing parameter to arch_vma_access_permitted From: "Xuetao Guan" To: "Guenter Roeck" Cc: "Guan Xuetao" , linux-kernel@vger.kernel.org, "Guenter Roeck" , "Dave Hansen" , "Thomas Gleixner" , "Ingo Molnar" Reply-To: gxt@mprc.pku.edu.cn User-Agent: SquirrelMail/1.4.8-4.0.1.el5 MIME-Version: 1.0 Content-Type: text/plain;charset=gb2312 Content-Transfer-Encoding: 8bit X-Priority: 3 (Normal) Importance: Normal Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1507 Lines: 45 > unicore32 fails to compile with the following errors. > > mm/memory.c: In function ‘__handle_mm_fault??�: > mm/memory.c:3381: error: > too many arguments to function ‘arch_vma_access_permitted??� > mm/gup.c: In function ‘check_vma_flags??�: > mm/gup.c:456: error: > too many arguments to function ‘arch_vma_access_permitted??� > mm/gup.c: In function ‘vma_permits_fault??�: > mm/gup.c:640: error: > too many arguments to function ‘arch_vma_access_permitted??� > > Fixes: d61172b4b695b ("mm/core, x86/mm/pkeys: Differentiate instruction > fetches") > Cc: Dave Hansen > Cc: Thomas Gleixner > Cc: Ingo Molnar > Signed-off-by: Guenter Roeck Thanks. Acked-by: Guan Xuetao > --- > arch/unicore32/include/asm/mmu_context.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/unicore32/include/asm/mmu_context.h > b/arch/unicore32/include/asm/mmu_context.h > index e35632ef23c7..62dfc644c908 100644 > --- a/arch/unicore32/include/asm/mmu_context.h > +++ b/arch/unicore32/include/asm/mmu_context.h > @@ -98,7 +98,7 @@ static inline void arch_bprm_mm_init(struct mm_struct > *mm, > } > > static inline bool arch_vma_access_permitted(struct vm_area_struct *vma, > - bool write, bool foreign) > + bool write, bool execute, bool foreign) > { > /* by default, allow everything */ > return true; > -- > 2.5.0 >