Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754360AbcCXAlO (ORCPT <rfc822;w@1wt.eu>);
	Wed, 23 Mar 2016 20:41:14 -0400
Received: from mprc.pku.edu.cn ([162.105.203.9]:53427 "EHLO mprc.pku.edu.cn"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753962AbcCXAlN (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 23 Mar 2016 20:41:13 -0400
Message-ID: <62869.117.114.135.40.1458779934.squirrel@mprc.pku.edu.cn>
In-Reply-To: <20160323202521.GA31744@roeck-us.net>
References: <1458559253-422-1-git-send-email-linux@roeck-us.net>
    <63436.117.114.135.40.1458560849.squirrel@mprc.pku.edu.cn>
    <20160323202521.GA31744@roeck-us.net>
Date: Thu, 24 Mar 2016 08:38:54 +0800 (CST)
Subject: Re: [PATCH] unicore32: mm: Add missing parameter to 
     arch_vma_access_permitted
From: "Xuetao Guan" <gxt@mprc.pku.edu.cn>
To: "Guenter Roeck" <linux@roeck-us.net>
Cc: "Xuetao Guan" <gxt@mprc.pku.edu.cn>, linux-kernel@vger.kernel.org,
        "Dave Hansen" <dave.hansen@linux.intel.com>,
        "Thomas Gleixner" <tglx@linutronix.de>,
        "Ingo Molnar" <mingo@kernel.org>
Reply-To: gxt@mprc.pku.edu.cn
User-Agent: SquirrelMail/1.4.8-4.0.1.el5
MIME-Version: 1.0
Content-Type: text/plain;charset=gb2312
Content-Transfer-Encoding: 8bit
X-Priority: 3 (Normal)
Importance: Normal
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1872
Lines: 63

> On Mon, Mar 21, 2016 at 07:47:29PM +0800, Xuetao Guan wrote:
>> > unicore32 fails to compile with the following errors.
>> >
>> > mm/memory.c: In function 鈥榑_handle_mm_fault??&#65533;&#65533;:
>> > mm/memory.c:3381: error:
>> > 	too many arguments to function
>> 鈥榓rch_vma_access_permitted??&#65533;&#65533;
>> > mm/gup.c: In function 鈥榗heck_vma_flags??&#65533;&#65533;:
>> > mm/gup.c:456: error:
>> > 	too many arguments to function
>> 鈥榓rch_vma_access_permitted??&#65533;&#65533;
>> > mm/gup.c: In function 鈥榲ma_permits_fault??&#65533;&#65533;:
>> > mm/gup.c:640: error:
>> > 	too many arguments to function
>> 鈥榓rch_vma_access_permitted??&#65533;&#65533;
>> >
>> > Fixes: d61172b4b695b ("mm/core, x86/mm/pkeys: Differentiate
>> instruction
>> > fetches")
>> > Cc: Dave Hansen <dave.hansen@linux.intel.com>
>> > Cc: Thomas Gleixner <tglx@linutronix.de>
>> > Cc: Ingo Molnar <mingo@kernel.org>
>> > Signed-off-by: Guenter Roeck <linux@roeck-us.net>
>>
>> Thanks.
>>
>> Acked-by: Guan Xuetao <gxt@mprc.pku.edu.cn>
>>
> Who is going to send the patch upstream ?
>
> Guenter

I will do. Thanks.

Xuetao

>
>> > ---
>> >  arch/unicore32/include/asm/mmu_context.h | 2 +-
>> >  1 file changed, 1 insertion(+), 1 deletion(-)
>> >
>> > diff --git a/arch/unicore32/include/asm/mmu_context.h
>> > b/arch/unicore32/include/asm/mmu_context.h
>> > index e35632ef23c7..62dfc644c908 100644
>> > --- a/arch/unicore32/include/asm/mmu_context.h
>> > +++ b/arch/unicore32/include/asm/mmu_context.h
>> > @@ -98,7 +98,7 @@ static inline void arch_bprm_mm_init(struct
>> mm_struct
>> > *mm,
>> >  }
>> >
>> >  static inline bool arch_vma_access_permitted(struct vm_area_struct
>> *vma,
>> > -		bool write, bool foreign)
>> > +		bool write, bool execute, bool foreign)
>> >  {
>> >  	/* by default, allow everything */
>> >  	return true;
>> > --
>> > 2.5.0
>> >
>>
>