Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758158AbcDAGbJ (ORCPT ); Fri, 1 Apr 2016 02:31:09 -0400 Received: from mx2.suse.de ([195.135.220.15]:60844 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753323AbcDAGbI (ORCPT ); Fri, 1 Apr 2016 02:31:08 -0400 Date: Fri, 1 Apr 2016 08:31:05 +0200 (CEST) From: Jiri Kosina X-X-Sender: jkosina@pobox.suse.cz To: Rusty Russell cc: linux-kernel@vger.kernel.org, Andrew Morton Subject: Re: [PATCH v2] module: fix noreturn attribute for __module_put_and_exit() In-Reply-To: <87k2ki8apc.fsf@rustcorp.com.au> Message-ID: References: <87k2ki8apc.fsf@rustcorp.com.au> User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 909 Lines: 29 On Fri, 1 Apr 2016, Rusty Russell wrote: > >> __module_put_and_exit() is makred noreturn in module.h declaration, but is > >> lacking the attribute in the definition, which makes some tools (such as > >> sparse) unhappy. Amend the definition with the attribute as well (and > >> reformat the declaration so that it uses more common format). > >> > >> Signed-off-by: Jiri Kosina > >> --- > >> > >> v1 -> v2: use __noreturn instead of __attribute__((noreturn)) as requested > >> by Rusty > > > > Rusty, friendly ping on this one. > > > > Thanks! > > Oops, I applied it, and in testing noted that lguest had broken and > ended up getting distracted by that. I've acked it now (it will > probably wait until next merge window). Sorry, non comprende :) Could you please elaborate? Are you saying this patch broke lguest? What is the breakage about? Thanks, -- Jiri Kosina SUSE Labs