Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754854AbcDAHDv (ORCPT ); Fri, 1 Apr 2016 03:03:51 -0400 Received: from mga03.intel.com ([134.134.136.65]:65203 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751280AbcDAHDu (ORCPT ); Fri, 1 Apr 2016 03:03:50 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,426,1455004800"; d="scan'208";a="936060526" Date: Fri, 1 Apr 2016 07:20:59 +0800 From: Yuyang Du To: bsegall@google.com Cc: peterz@infradead.org, mingo@kernel.org, linux-kernel@vger.kernel.org, pjt@google.com, morten.rasmussen@arm.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, lizefan@huawei.com, umgwanakikbuti@gmail.com Subject: Re: [PATCH RESEND v2 6/6] sched/fair: Remove unconditionally inactive code Message-ID: <20160331232059.GE22689@intel.com> References: <1459369015-28375-1-git-send-email-yuyang.du@intel.com> <1459369015-28375-7-git-send-email-yuyang.du@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1047 Lines: 27 On Thu, Mar 31, 2016 at 10:53:02AM -0700, bsegall@google.com wrote: > Yuyang Du writes: > > > The increased load resolution (fixed point arithmetic range) is > > unconditionally deactivated with #if 0, so it is effectively broken. > > > > But the increased load range is still used somewhere (e.g., in Google), > > so we keep this feature. The reconciliation is we define > > CONFIG_CFS_INCREASE_LOAD_RANGE and it depends on FAIR_GROUP_SCHED and > > 64BIT and BROKEN. > > > > Suggested-by: Ingo Molnar > > Signed-off-by: Yuyang Du > > The title of this patch "Remove unconditionally inactive code" is > misleading since it's more like giving it a CONFIG. Reasonable argument. > > Also as a side note, does anyone remember/have a test for whatever got > it turned off to begin with, given all the changes in load tracking and > the load balancer and everything else? It is this commit that turned it off: Commit e4c2fb0d5776: "sched: Disable (revert) SCHED_LOAD_SCALE increase"