Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758503AbcDAHTi (ORCPT ); Fri, 1 Apr 2016 03:19:38 -0400 Received: from mx0a-0016f401.pphosted.com ([67.231.148.174]:8650 "EHLO mx0a-0016f401.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750741AbcDAHTh (ORCPT ); Fri, 1 Apr 2016 03:19:37 -0400 Date: Fri, 1 Apr 2016 15:15:32 +0800 From: Jisheng Zhang To: David Miller CC: , , , Subject: Re: [PATCH] net: mvneta: replace MVNETA_CPU_D_CACHE_LINE_SIZE with L1_CACHE_BYTES Message-ID: <20160401151532.3c596206@xhacker> In-Reply-To: <20160331.164710.1998871529914699937.davem@davemloft.net> References: <1459338921-391-1-git-send-email-jszhang@marvell.com> <20160331.151547.1889188465826831929.davem@davemloft.net> <20160331223735.32904e42@free-electrons.com> <20160331.164710.1998871529914699937.davem@davemloft.net> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-04-01_03:,, signatures=0 X-Proofpoint-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=2 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1601100000 definitions=main-1604010099 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1100 Lines: 38 Hi David, Thomas, On Thu, 31 Mar 2016 16:47:10 -0400 David Miller wrote: > From: Thomas Petazzoni > Date: Thu, 31 Mar 2016 22:37:35 +0200 > > > Hello, > > > > On Thu, 31 Mar 2016 15:15:47 -0400 (EDT), David Miller wrote: > >> From: Jisheng Zhang > >> Date: Wed, 30 Mar 2016 19:55:21 +0800 > >> > >> > The mvneta is also used in some Marvell berlin family SoCs which may > >> > have 64bytes cacheline size. Replace the MVNETA_CPU_D_CACHE_LINE_SIZE > >> > usage with L1_CACHE_BYTES. > >> > > >> > And since dma_alloc_coherent() is always cacheline size aligned, so > >> > remove the align checks. > >> > > >> > Signed-off-by: Jisheng Zhang > >> > >> Applied. > > > > A new version of the patch was sent, which more rightfully uses > > cache_line_size(), see: > > > > "[PATCH v2] net: mvneta: replace MVNETA_CPU_D_CACHE_LINE_SIZE with cache_line_size" > > Sorry about that. > > Send me a realtive fixup patch if you like. > Sorry about inconvenience, I'll send out fixup patch. Thanks, Jisheng