Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753634AbcDAJHk (ORCPT ); Fri, 1 Apr 2016 05:07:40 -0400 Received: from mailapp01.imgtec.com ([195.59.15.196]:1582 "EHLO mailapp01.imgtec.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753064AbcDAJHf (ORCPT ); Fri, 1 Apr 2016 05:07:35 -0400 Subject: Re: [PATCH v2 11/11] MIPS: KASLR: Print relocation Information on boot To: Ralf Baechle , Sergei Shtylyov References: <1459415142-3412-1-git-send-email-matt.redfearn@imgtec.com> <1459415142-3412-12-git-send-email-matt.redfearn@imgtec.com> <56FD1A32.10204@cogentembedded.com> <20160401084403.GA28123@linux-mips.org> CC: , , "Aaro Koskinen" , Masahiro Yamada , Alexander Sverdlin , , Jaedon Shin , Jonas Gorski , Paul Burton From: Matt Redfearn Message-ID: <56FE3A54.4020102@imgtec.com> Date: Fri, 1 Apr 2016 10:07:32 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <20160401084403.GA28123@linux-mips.org> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [192.168.154.116] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1623 Lines: 47 On 01/04/16 09:44, Ralf Baechle wrote: > On Thu, Mar 31, 2016 at 03:38:10PM +0300, Sergei Shtylyov wrote: > >>> When debugging a relocated kernel, the addresses of the relocated >>> symbols and the offset applied is essential information. If the kernel >>> is compiled with debugging information, then print this information >>> during bootup using the same function as the panic notifer. >> Notifier. > Fixed when merging. > >>> Signed-off-by: Matt Redfearn >>> --- >>> >>> Changes in v2: None >>> >>> arch/mips/kernel/setup.c | 9 +++++++++ >>> 1 file changed, 9 insertions(+) >>> >>> diff --git a/arch/mips/kernel/setup.c b/arch/mips/kernel/setup.c >>> index d8376d7b3345..ae71f8d9b555 100644 >>> --- a/arch/mips/kernel/setup.c >>> +++ b/arch/mips/kernel/setup.c >>> @@ -477,9 +477,18 @@ static void __init bootmem_init(void) >>> */ >>> if (__pa_symbol(_text) > __pa_symbol(VMLINUX_LOAD_ADDRESS)) { >>> unsigned long offset; >>> + extern void show_kernel_relocation(const char *level); >>> >>> offset = __pa_symbol(_text) - __pa_symbol(VMLINUX_LOAD_ADDRESS); >>> free_bootmem(__pa_symbol(VMLINUX_LOAD_ADDRESS), offset); >>> + >>> +#if (defined CONFIG_DEBUG_KERNEL) && (defined CONFIG_DEBUG_INFO) >> Not #if defined(CONFIG_DEBUG_KERNEL) && defined(CONFIG_DEBUG_INFO)? >> >> [...] > CPP syntax is not what most people seem to believe that is the parenthesis > around the argument of defined are not required so above line is unusual > but perfectly ok. However following boring standards is good so I changed > this, too. > > Ralf Great, thanks Ralf. Matt