Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754107AbcDAJVI (ORCPT ); Fri, 1 Apr 2016 05:21:08 -0400 Received: from smtprelay4.synopsys.com ([198.182.47.9]:44869 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751432AbcDAJVF (ORCPT ); Fri, 1 Apr 2016 05:21:05 -0400 Subject: Re: [PATCH v12 3/9] added UFS 2.0 capabilities To: "Winkler, Tomas" , "Joao.Pinto@synopsys.com" References: <40585ae835f02d3b5550a32553b2189754e365b6.1459448160.git.jpinto@synopsys.com> <1459455981.23778.31.camel@intel.com> CC: "vinholikatti@gmail.com" , "linux-kernel@vger.kernel.org" , "hch@infradead.org" , "akinobu.mita@gmail.com" , "devicetree@vger.kernel.org" , "gbroner@codeaurora.org" , "subhashj@codeaurora.org" , "CARLOS.PALMINHA@synopsys.com" , "linux-scsi@vger.kernel.org" , "mark.rutland@arm.com" , "ijc+devicetree@hellion.org.uk" , "julian.calaby@gmail.com" , "arnd@arndb.de" From: Joao Pinto Message-ID: <56FE3D13.6070504@synopsys.com> Date: Fri, 1 Apr 2016 10:19:15 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <1459455981.23778.31.camel@intel.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.13.184.19] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 827 Lines: 33 On 3/31/2016 9:27 PM, Winkler, Tomas wrote: > On Thu, 2016-03-31 at 19:57 +0100, Joao Pinto wrote: >> Adding UFS 2.0 support to the UFS core driver. >> >> Signed-off-by: Joao Pinto > > Looks good to me, though not tested yet > Tomas I have tested the build in a x86 and ARC. Also tested the functionality by using a HAPS-DX FPGA with the UFS 2.0 design + MPHY G210. > >> --- >> Changes v11->v12 (Tomas Winkler): >> - devicetree binding tweak was moved to a separated patch >> - unipro tweaks were moved to a separated patch >> - ufshcd_compose_upiu was decomposed in 2 functions [snip] >> +enum { >> + UTP_CMD_TYPE_UFS_STORAGE = 0x1, >> +}; >> + >> enum { >> UTP_SCSI_COMMAND = 0x00000000, >> UTP_NATIVE_UFS_COMMAND = 0x10000000, If you need anything else, please let me know. Thanks. Joao