Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753274AbcDAJrc (ORCPT ); Fri, 1 Apr 2016 05:47:32 -0400 Received: from comal.ext.ti.com ([198.47.26.152]:55279 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750963AbcDAJr3 (ORCPT ); Fri, 1 Apr 2016 05:47:29 -0400 Subject: Re: [PATCH v3 2/2] usb:dwc3: pass arch data to xhci-hcd child To: Felipe Balbi , "Thang Q. Nguyen" References: <1457594332-7490-1-git-send-email-tqnguyen@apm.com> <1457594332-7490-3-git-send-email-tqnguyen@apm.com> <87mvpgi02f.fsf@intel.com> <56FBDA0D.4030507@ti.com> <87egashxz8.fsf@intel.com> <87k2kjgjjf.fsf@intel.com> <56FD3D2F.8070501@ti.com> <871t6pahg8.fsf@intel.com> CC: Greg Kroah-Hartman , , , , , Arnd Bergmann , "Karicheri, Muralidharan" , Peter Ujfalusi , Phong Vo , Loc Ho , patches , Santosh Shilimkar , "Ben Dooks (embedded platforms)" From: Grygorii Strashko Message-ID: <56FE4378.3030205@ti.com> Date: Fri, 1 Apr 2016 12:46:32 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <871t6pahg8.fsf@intel.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3086 Lines: 79 On 04/01/2016 10:58 AM, Felipe Balbi wrote: > > Hi, > > Grygorii Strashko writes: >> On 03/31/2016 11:04 AM, Felipe Balbi wrote: >>> "Thang Q. Nguyen" writes: >>>> [ text/plain ] >>>> Thanks Grygorii for information. >>>> I checked but do not see dma_init_dev_from_parent is used in >>>> linux-next repository. Can you give me more information for what >>>> branch I can checkout to use it for USB DWC3? >>> >>> dma_init_dev_from_parent() is still a proposal ;-) >>> >> >> Felipe, >> >> After some experiments I came up with below fix (not common, but fixes USB >> case on keystone 2). if you agree with proposed fix I'll send proper >> patches to fix usb_add_gadget_udc_release() and dwc3_host_init() in the same >> way. >> >> diff --git a/drivers/usb/dwc3/host.c b/drivers/usb/dwc3/host.c >> index c679f63..3fe1c65 100644 >> --- a/drivers/usb/dwc3/host.c >> +++ b/drivers/usb/dwc3/host.c >> @@ -17,6 +17,7 @@ >> >> #include >> #include >> +#include >> >> #include "core.h" >> >> @@ -35,8 +36,6 @@ int dwc3_host_init(struct dwc3 *dwc) >> dma_set_coherent_mask(&xhci->dev, dwc->dev->coherent_dma_mask); >> >> xhci->dev.parent = dwc->dev; >> - xhci->dev.dma_mask = dwc->dev->dma_mask; >> - xhci->dev.dma_parms = dwc->dev->dma_parms; >> >> dwc->xhci = xhci; >> >> @@ -62,6 +61,12 @@ int dwc3_host_init(struct dwc3 *dwc) >> phy_create_lookup(dwc->usb3_generic_phy, "usb3-phy", >> dev_name(&xhci->dev)); >> >> + if (!dwc->dev->of_node) { >> + xhci->dev.dma_mask = dwc->dev->dma_mask; >> + xhci->dev.dma_parms = dwc->dev->dma_parms; >> + } else >> + of_dma_configure(&xhci->dev, dwc->dev->of_node); > > if of_dma_configure() does what you want, why don't you just stick it in > dwc3-keystone.c and let the driver continue to copy things for now ? > Something like below, perhaps ? > I know (and i have patch to fix that which I'm going to send) that DMA config in dwc3-keystone.c is not correct and we are good till now just because dwc3_keystone is not used for DMA operations directly. Now about xhci and friends: dwc3_keystone *is created* from DT : of_platform_device_create() -> of_platform_device_create_pdata() -> of_dma_configure() |- dwc3 *is created* from DT : of_platform_device_create() -> of_platform_device_create_pdata() -> of_dma_configure() |- [1] *creates* xhci dev manually : DMA configuration copied manually in dwc3_host_init() |- [2] *creates* usb_gadget dev manually: DMA configuration copied manually in usb_add_gadget_udc_release() |- *creates* usb_udc dev manually : not used for DMA operations directly (as I've checked) Now cases [1] & [2] introduces failures, because DMA configuration is not complete for these devices. I can confirm that if I fix [1] & [2] as above USB Device/Dual modes will start working on K2E. -- regards, -grygorii