Reply-To: xlpang@redhat.com
Subject: Re: [PATCH] sched/deadline: No need to check NULL later_mask
References: <1459509198-26543-1-git-send-email-xlpang@redhat.com>
 <20160401112919.GP3430@twins.programming.kicks-ass.net>
To: Peter Zijlstra <peterz@infradead.org>
Cc: linux-kernel@vger.kernel.org, Juri Lelli <juri.lelli@arm.com>,
        Ingo Molnar <mingo@redhat.com>, Steven Rostedt <rostedt@goodmis.org>
From: Xunlei Pang <xpang@redhat.com>
Message-ID: <56FE66A5.9050004@redhat.com>
Date: Fri, 1 Apr 2016 20:16:37 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.2.0
MIME-Version: 1.0
In-Reply-To: <20160401112919.GP3430@twins.programming.kicks-ass.net>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 636
Lines: 18

On 2016/04/01 at 19:29, Peter Zijlstra wrote:
> On Fri, Apr 01, 2016 at 07:13:18PM +0800, Xunlei Pang wrote:
>> Unlike rt tasks, we (should) have no deadline tasks in
>> booting phase before the mask is allocated, so we can
>> safely remove the check.
> Why? And have the kernel explode once it grows an early deadline task?
>
> Is there _any_ benefit to this?

This is a performance-critical path, it'd be better to avoid such a check.

I think in the early boot stage before sched_init_smp(), it's weird to
use a deadline task, relying on rt tasks should be enough for us.

Please ignore it if you don't think so :-)

Regards,
Xunlei