Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759189AbcDANJe (ORCPT ); Fri, 1 Apr 2016 09:09:34 -0400 Received: from mailapp01.imgtec.com ([195.59.15.196]:63047 "EHLO mailapp01.imgtec.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759165AbcDANJb (ORCPT ); Fri, 1 Apr 2016 09:09:31 -0400 Subject: Re: [PATCH 01/12] mtd: nand: remove unneeded of_mtd.h inclusions To: Boris Brezillon , Roger Quadros , Tony Lindgren , Wenyou Yang , Josh Wu , Richard Weinberger , , David Woodhouse , Brian Norris , Kamal Dasu , Han Xu , Ezequiel Garcia , Stefan Agner References: <1459515272-31011-1-git-send-email-boris.brezillon@free-electrons.com> <1459515272-31011-2-git-send-email-boris.brezillon@free-electrons.com> CC: , Nicolas Ferre , Jean-Christophe Plagniol-Villard , Alexandre Belloni , Thomas Petazzoni , Gregory CLEMENT , Jason Cooper , Sebastian Hesselbarth , Andrew Lunn , Daniel Mack , Haojian Zhuang , Robert Jarzmik , , , , Maxime Ripard , Chen-Yu Tsai , , Zhou Wang , Alex Smith From: Harvey Hunt Message-ID: <56FE7307.6040903@imgtec.com> Date: Fri, 1 Apr 2016 14:09:27 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.1 MIME-Version: 1.0 In-Reply-To: <1459515272-31011-2-git-send-email-boris.brezillon@free-electrons.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [192.168.154.26] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 998 Lines: 35 Hi Boris, On 01/04/16 13:54, Boris Brezillon wrote: > Some drivers are including linux/of_mtd.h even if they don't use any of > the of_get_nand_xxx() helpers. > > Signed-off-by: Boris Brezillon > --- > drivers/mtd/nand/jz4780_nand.c | 1 - > drivers/mtd/nand/lpc32xx_mlc.c | 1 - > drivers/mtd/nand/qcom_nandc.c | 1 - > drivers/mtd/nand/sunxi_nand.c | 1 - > drivers/mtd/nand/vf610_nfc.c | 1 - > 5 files changed, 5 deletions(-) > > diff --git a/drivers/mtd/nand/jz4780_nand.c b/drivers/mtd/nand/jz4780_nand.c > index e1c016c..23a1999 100644 > --- a/drivers/mtd/nand/jz4780_nand.c > +++ b/drivers/mtd/nand/jz4780_nand.c > @@ -17,7 +17,6 @@ > #include > #include > #include > -#include > #include > #include > #include Looks good to me. Acked-by: Harvey Hunt Thanks, Harvey