Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757706AbcDANMp (ORCPT ); Fri, 1 Apr 2016 09:12:45 -0400 Received: from casper.infradead.org ([85.118.1.10]:47151 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753236AbcDANMo (ORCPT ); Fri, 1 Apr 2016 09:12:44 -0400 User-Agent: K-9 Mail for Android In-Reply-To: <56FE685E.6080001@redhat.com> References: <1459508418-25577-1-git-send-email-xlpang@redhat.com> <20160401113827.GQ3430@twins.programming.kicks-ass.net> <56FE685E.6080001@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Subject: Re: [PATCH] sched/deadline/rtmutex: Fix a PI crash for deadline tasks From: Peter Zijlstra Date: Fri, 01 Apr 2016 15:12:34 +0200 To: xlpang@redhat.com, Xunlei Pang CC: linux-kernel@vger.kernel.org, Juri Lelli , Ingo Molnar , Steven Rostedt Message-ID: <19912883-8AB1-4DFD-A0E1-F23057785243@infradead.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 554 Lines: 18 On 1 April 2016 14:23:58 CEST, Xunlei Pang wrote: >>> We need this iff lock owner has the deadline priority. >> How is this deadline specific, those functions you modify are >> deadline/rt agnostic. > >I checked the code, currently only deadline accesses the >pi_waiters/pi_waiters_leftmost >without pi_lock held via rt_mutex_get_top_task(), other cases all have >pi_lock held. > >So adding the condition. How does that not suggest fixing the deadline code? -- Sent from my Android device with K-9 Mail. Please excuse my brevity.