Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758934AbcDAOam (ORCPT ); Fri, 1 Apr 2016 10:30:42 -0400 Received: from mail-wm0-f42.google.com ([74.125.82.42]:37816 "EHLO mail-wm0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754748AbcDAOaj (ORCPT ); Fri, 1 Apr 2016 10:30:39 -0400 Subject: Re: [PATCH v3 12/18] dt-bindings: Add PLX Technology OXNAS pinctrl and gpio bindings To: Rob Herring , Linus Walleij References: <1458838215-23314-1-git-send-email-narmstrong@baylibre.com> <1458838215-23314-13-git-send-email-narmstrong@baylibre.com> <20160325144834.GA27177@rob-hp-laptop> Cc: "linux-kernel@vger.kernel.org" , Russell King - ARM Linux , "linux-arm-kernel@lists.infradead.org" , "linux-gpio@vger.kernel.org" , "devicetree@vger.kernel.org" From: Neil Armstrong Organization: Baylibre Message-ID: <56FE8602.8020405@baylibre.com> Date: Fri, 1 Apr 2016 16:30:26 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1455 Lines: 40 On 03/31/2016 03:36 PM, Rob Herring wrote: > On Thu, Mar 31, 2016 at 3:58 AM, Linus Walleij wrote: >> On Fri, Mar 25, 2016 at 3:48 PM, Rob Herring wrote: >>> On Thu, Mar 24, 2016 at 05:50:09PM +0100, Neil Armstrong wrote: >>>> Add pinctrl and gpio DT bindings for PLX Technology OXNAS SoC Family. >>>> This version supports the ARM926EJ-S based OX810SE SoC with 34 IO pins. >>>> >>>> Signed-off-by: Neil Armstrong >> >>>> + - plxtech,gpio-bank: Specifies which bank a controller owns. >>> >>> How is this used? >> >> That is used to give a unique ID number to the bank. >> >> Hardware often need this to cross-reference pin controllers >> to GPIO banks. >> >> I should add it as "gpio-bank" to the generic bindings >> instead, several platforms already use this and there is >> no point in having a vendor prefix in front of it. > > Okay, now it is clearer. I don't want this documented as a common > property because I don't want to encourage it's use. I only see 2 > users currently: ST and PIC32. > > Looking at one example, it appears to be redundant already. > nomadik-gpio-chips property already gives you the index. The index of > the phandles is the bank numbering. PIC32 could do the same. > > Rob > Hi, What should I use ? I need to repost in a separate patchset with vendor replaced by Oxford Semiconductor. Should I get rid of the vendor prefix of gpio-bank ? Neil