Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752879AbcDAPiV (ORCPT ); Fri, 1 Apr 2016 11:38:21 -0400 Received: from mx2.suse.de ([195.135.220.15]:43807 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751281AbcDAPiU (ORCPT ); Fri, 1 Apr 2016 11:38:20 -0400 Date: Fri, 1 Apr 2016 17:38:18 +0200 From: Petr Mladek To: Josh Poimboeuf Cc: Jiri Kosina , Jessica Yu , Miroslav Benes , linux-kernel@vger.kernel.org, live-patching@vger.kernel.org, Vojtech Pavlik Subject: Re: [RFC PATCH v1.9 00/14] livepatch: hybrid consistency model Message-ID: <20160401153817.GF1023@pathway.suse.cz> References: <20160401133944.GQ5522@pathway.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160401133944.GQ5522@pathway.suse.cz> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1403 Lines: 38 On Fri 2016-04-01 15:39:44, Petr Mladek wrote: > On Fri 2016-03-25 14:34:47, Josh Poimboeuf wrote: > > These patches are still a work in progress, but Jiri asked that I share > > them before I go on vacation next week. Based on origin/master because > > it has CONFIG_STACK_VALIDATION. > > I have to follow Mirek and say that it is a great work. > > > There's also a func->immediate flag which allows users to specify that > > certain functions in the patch can be applied without per-task > > consistency. This might be useful if you want to patch a common > > function like schedule(), and the function change doesn't need > > consistency but the rest of the patch does. > > I like the possibility to immediately patch some functions or objects. > Just note that this is not yet completely implemented and it is not > on the TODO list. Correction. Only patch and func can be marked by the "immediate" flag, not an object. It looks fine. > We probably should not set func->transition flag when func->immediate > is set or when the related func->object is set. It currently happens > only when patch->immediate is set. This is true but only for func->transition. > Also we should ignore immediate functions and objects when the stack > is checked. This is already done. I have missed this. I am sorry for confusion. I should have shaken my head even more before writing. Best Regards, Petr