Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751778AbcDAQZK (ORCPT ); Fri, 1 Apr 2016 12:25:10 -0400 Received: from mail-pa0-f50.google.com ([209.85.220.50]:33200 "EHLO mail-pa0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750804AbcDAQZI (ORCPT ); Fri, 1 Apr 2016 12:25:08 -0400 Subject: Re: [PATCH 2/3] staging: fwserial: (coding style) removing "!= NULL" to comply with checkpatch.pl To: Dominique van den Broeck References: <1459271662-14990-1-git-send-email-domdevlin@free.fr> <1459271662-14990-2-git-send-email-domdevlin@free.fr> Cc: Greg Kroah-Hartman , Shraddha Barke , Radek Dostal , linux-kernel@vger.kernel.org From: Peter Hurley Message-ID: <56FEA0DF.3030208@hurleysoftware.com> Date: Fri, 1 Apr 2016 09:25:03 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <1459271662-14990-2-git-send-email-domdevlin@free.fr> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 432 Lines: 10 On 03/29/2016 10:14 AM, Dominique van den Broeck wrote: > Removing two "!= NULL" from fwserial.c as suggested by checkpatch.pl. > Note that the associated expression "port->port.console" is a 1-bit-field > that is already assumed as an implicit boolean (that is: without comparison) Similarly, please change $subject to "staging: fwserial: Simplify NULL ptr check" With that, Reviewed-by: Peter Hurley