Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752065AbcDASLr (ORCPT ); Fri, 1 Apr 2016 14:11:47 -0400 Received: from mx0b-00082601.pphosted.com ([67.231.153.30]:2864 "EHLO mx0b-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751022AbcDASLq (ORCPT ); Fri, 1 Apr 2016 14:11:46 -0400 Subject: Re: [RFC PATCH 6/6] ppc: ebpf/jit: Implement JIT compiler for extended BPF To: "Naveen N. Rao" , , References: CC: , Matt Evans , Michael Ellerman , Paul Mackerras , "David S. Miller" , Ananth N Mavinakayanahalli , , Daniel Borkmann From: Alexei Starovoitov Message-ID: <56FEB9AD.2080401@fb.com> Date: Fri, 1 Apr 2016 11:10:53 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:38.0) Gecko/20100101 Thunderbird/38.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [192.168.52.123] X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-04-01_07:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1956 Lines: 50 On 4/1/16 2:58 AM, Naveen N. Rao wrote: > PPC64 eBPF JIT compiler. Works for both ABIv1 and ABIv2. > > Enable with: > echo 1 > /proc/sys/net/core/bpf_jit_enable > or > echo 2 > /proc/sys/net/core/bpf_jit_enable > > ... to see the generated JIT code. This can further be processed with > tools/net/bpf_jit_disasm. > > With CONFIG_TEST_BPF=m and 'modprobe test_bpf': > test_bpf: Summary: 291 PASSED, 0 FAILED, [234/283 JIT'ed] > > ... on both ppc64 BE and LE. > > The details of the approach are documented through various comments in > the code, as are the TODOs. Some of the prominent TODOs include > implementing BPF tail calls and skb loads. > > Cc: Matt Evans > Cc: Michael Ellerman > Cc: Paul Mackerras > Cc: Alexei Starovoitov > Cc: "David S. Miller" > Cc: Ananth N Mavinakayanahalli > Signed-off-by: Naveen N. Rao > --- > arch/powerpc/include/asm/ppc-opcode.h | 19 +- > arch/powerpc/net/Makefile | 4 + > arch/powerpc/net/bpf_jit.h | 66 ++- > arch/powerpc/net/bpf_jit64.h | 58 +++ > arch/powerpc/net/bpf_jit_comp64.c | 828 ++++++++++++++++++++++++++++++++++ > 5 files changed, 973 insertions(+), 2 deletions(-) > create mode 100644 arch/powerpc/net/bpf_jit64.h > create mode 100644 arch/powerpc/net/bpf_jit_comp64.c ... > -#ifdef CONFIG_PPC64 > +#if defined(CONFIG_PPC64) && (!defined(_CALL_ELF) || _CALL_ELF != 2) impressive stuff! Everything nicely documented. Could you add few words for the above condition as well ? Or may be a new macro, since it occurs many times? What are these _CALL_ELF == 2 and != 2 conditions mean? ppc ABIs ? Will there ever be v3 ? So far most of the bpf jits were going via net-next tree, but if in this case no changes to the core is necessary then I guess it's fine to do it via powerpc tree. What's your plan?