Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753859AbcDAVYL (ORCPT ); Fri, 1 Apr 2016 17:24:11 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:48606 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751484AbcDAVYJ (ORCPT ); Fri, 1 Apr 2016 17:24:09 -0400 From: Christopher Covington To: Greg Kroah-Hartman , linux-serial@vger.kernel.org Cc: Andre Przywara , Russell King , Dave Martin , Jim Perrin , Jon Masters , Mark Langsdorf , Mark Salter , Timur Tabi , Aleksey Makarov , Christopher Covington , Jiri Slaby , linux-kernel@vger.kernel.org Subject: [PATCH v3] tty: amba-pl011: Use 32-bit accesses for SBSA UART Date: Fri, 1 Apr 2016 17:23:58 -0400 Message-Id: <1459545838-17646-1-git-send-email-cov@codeaurora.org> X-Mailer: git-send-email 2.8.0 In-Reply-To: <20160330165551.GB23817@kroah.com> References: <20160330165551.GB23817@kroah.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1509 Lines: 38 Version 2 of the Server Base System Architecture (SBSAv2) describes UART hardware registers as 32 bits wide, giving no guidance on access sizes. The SBSA UART driver previously assumed partial-length 16 and 8 bit accesses would work. But the SBSAv2 UART hardware on the Qualcomm Technologies QDF2432 only supports full-length 32 bit register accesses, so use those exclusively. This is compatible with SBSAv3, which explicitly requires UART hardware support 32 (and 16 and sometimes 8) bit accesses. Tested on Juno, Midway, QDF2432, Seattle, and X-Gene 1. Tested-by: Mark Langsdorf Tested-by: Andre Przywara Acked-by: Andre Przywara Signed-off-by: Christopher Covington --- Changes since v2: * Updated commit message * Added Andre's Acked-by and Tested-by. --- drivers/tty/serial/amba-pl011.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/tty/serial/amba-pl011.c b/drivers/tty/serial/amba-pl011.c index 7c198e0..a2aa655 100644 --- a/drivers/tty/serial/amba-pl011.c +++ b/drivers/tty/serial/amba-pl011.c @@ -121,6 +121,7 @@ static struct vendor_data vendor_arm = { static struct vendor_data vendor_sbsa = { .reg_offset = pl011_std_offsets, + .access_32b = true, .oversampling = false, .dma_threshold = false, .cts_event_workaround = false, -- Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project