Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754257AbcDAVkh (ORCPT ); Fri, 1 Apr 2016 17:40:37 -0400 Received: from mail-pf0-f177.google.com ([209.85.192.177]:36707 "EHLO mail-pf0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752459AbcDAVkf (ORCPT ); Fri, 1 Apr 2016 17:40:35 -0400 Subject: Re: [RFC PATCH] sched/fair: call cpufreq hook in additional paths To: Peter Zijlstra References: <1458858367-2831-1-git-send-email-smuckle@linaro.org> <20160331075951.GG3408@twins.programming.kicks-ass.net> <20160331091426.GE11035@twins.programming.kicks-ass.net> Cc: Ingo Molnar , "Rafael J. Wysocki" , linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Vincent Guittot , Morten Rasmussen , Dietmar Eggemann , Juri Lelli , Patrick Bellasi , Michael Turquette , Byungchul Park From: Steve Muckle X-Enigmail-Draft-Status: N1110 Message-ID: <56FEEAD0.2040108@linaro.org> Date: Fri, 1 Apr 2016 14:40:32 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.0 MIME-Version: 1.0 In-Reply-To: <20160331091426.GE11035@twins.programming.kicks-ass.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1079 Lines: 26 On 03/31/2016 02:14 AM, Peter Zijlstra wrote: > On Thu, Mar 31, 2016 at 09:59:51AM +0200, Peter Zijlstra wrote: >>> > > - passing an argument into attach_entity_load_avg() to indicate >>> > > whether calling the cpufreq hook is necessary >>> > > >>> > > Both of these are ugly in their own way but would avoid a runtime >>> > > cost. Opinions welcome. >> > >> > Lemme see what this would look like while I throw the below into the bit >> > bucket. > OK, so the below looks a lot more sane; and has the surprising benefit > of actually shrinking the text size.. > > 43675 1226 24 44925 af7d defconfig-build/kernel/sched/fair.o.base > 43723 1226 24 44973 afad defconfig-build/kernel/sched/fair.o.patch > 43595 1226 24 44845 af2d defconfig-build/kernel/sched/fair.o.patch+ > > --- > --- a/kernel/sched/fair.c > +++ b/kernel/sched/fair.c Cool, thanks. Shall I fold this into this patch and resend the series of 3? Or would you prefer to add this change separately? thanks, Steve