Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755498AbcDAX0B (ORCPT ); Fri, 1 Apr 2016 19:26:01 -0400 Received: from mail-pa0-f45.google.com ([209.85.220.45]:33160 "EHLO mail-pa0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753797AbcDAXZ6 (ORCPT ); Fri, 1 Apr 2016 19:25:58 -0400 From: Kevin Hilman To: Jon Hunter Cc: Thomas Gleixner , Jason Cooper , Marc Zyngier , =?utf-8?Q?Beno=C3=AEt?= Cousson , Tony Lindgren , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Stephen Warren , Thierry Reding , Geert Uytterhoeven , Grygorii Strashko , Lars-Peter Clausen , Linus Walleij , linux-tegra@vger.kernel.org, linux-omap@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 01/15] ARM: tegra: Correct interrupt type for ARM TWD Organization: BayLibre References: <1458224359-32665-1-git-send-email-jonathanh@nvidia.com> <1458224359-32665-2-git-send-email-jonathanh@nvidia.com> Date: Fri, 01 Apr 2016 16:25:56 -0700 In-Reply-To: <1458224359-32665-2-git-send-email-jonathanh@nvidia.com> (Jon Hunter's message of "Thu, 17 Mar 2016 14:19:05 +0000") Message-ID: <7h60w0oqrf.fsf@baylibre.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 634 Lines: 16 Jon Hunter writes: > The ARM TWD interrupt is a private peripheral interrupt (PPI) and per > the ARM GIC documentation, whether the type for PPIs can be set is > IMPLEMENTATION DEFINED. For Tegra20/30 devices the PPI type cannot be > set and so when we attempt to set the type for the ARM TWD interrupt it > fails. This has done unnoticed because it fails silently and because we nit: s/done/gone/ > cannot re-configure the type it has had no impact. Nevertheless fix the > type for the TWD interrupt so that it matches the hardware configuration. > > Signed-off-by: Jon Hunter Kevin