Subject: Re: [RFC][PATCH] mm/slub: Skip CPU slab activation when debugging
To: Joonsoo Kim <iamjoonsoo.kim@lge.com>
References: <1459205581-4605-1-git-send-email-labbott@fedoraproject.org>
 <20160401023533.GB13179@js1304-P5Q-DELUXE> <56FEF2F8.7010508@redhat.com>
Cc: Christoph Lameter <cl@linux.com>, Pekka Enberg <penberg@kernel.org>,
        David Rientjes <rientjes@google.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Laura Abbott <labbott@fedoraproject.org>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org, Kees Cook <keescook@chromium.org>
From: Laura Abbott <labbott@redhat.com>
Message-ID: <56FF0979.5060000@redhat.com>
Date: Fri, 1 Apr 2016 16:51:21 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.7.1
MIME-Version: 1.0
In-Reply-To: <56FEF2F8.7010508@redhat.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2296
Lines: 60

On 04/01/2016 03:15 PM, Laura Abbott wrote:
> On 03/31/2016 07:35 PM, Joonsoo Kim wrote:
>> On Mon, Mar 28, 2016 at 03:53:01PM -0700, Laura Abbott wrote:
>>> The per-cpu slab is designed to be the primary path for allocation in SLUB
>>> since it assumed allocations will go through the fast path if possible.
>>> When debugging is enabled, the fast path is disabled and per-cpu
>>> allocations are not used. The current debugging code path still activates
>>> the cpu slab for allocations and then immediately deactivates it. This
>>> is useless work. When a slab is enabled for debugging, skip cpu
>>> activation.
>>>
>>> Signed-off-by: Laura Abbott <labbott@fedoraproject.org>
>>> ---
>>> This is a follow on to the optimization of the debug paths for poisoning
>>> With this I get ~2 second drop on hackbench -g 20 -l 1000 with slub_debug=P
>>> and no noticable change with slub_debug=- .
>>
>> I'd like to know the performance difference between slub_debug=P and
>> slub_debug=- with this change.
>>
>
> with the hackbench benchmark
>
> slub_debug=- 6.834
>
> slub_debug=P 8.059
>
>
> so ~1.2 second difference.
>
>> Although this patch increases hackbench performance, I'm not sure it's
>> sufficient for the production system. Concurrent slab allocation request
>> will contend the node lock in every allocation attempt. So, there would be
>> other ues-cases that performance drop due to slub_debug=P cannot be
>> accepted even if it is security feature.
>>
>
> Hmmm, I hadn't considered that :-/
>
>> How about allowing cpu partial list for debug cases?
>> It will not hurt fast path and will make less contention on the node
>> lock.
>>
>
> That helps more than this patch! It brings slub_debug=P down to 7.535
> with the same relaxing of restrictions of CMPXCHG (allow the partials
> with poison or redzoning, restrict otherwise).
>
> It still seems unfortunate that deactive_slab takes up so much time
> of __slab_alloc. I'll give some more thought about trying to skip
> the CPU slab activation with the cpu partial list.
>

I realized I was too eager about the number there. That number includes
using the slow path since the CPU partial list activates the fast path.
I'll need to think about how to use the CPU partial list and still
force debugging on the slow path.

Thanks,
Laura